Skip to content

[HLSL] Add Load overload with status #166449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 21, 2025
Merged

[HLSL] Add Load overload with status #166449

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
99c9788
as far as I can go without adding CAFM
bob80905 Oct 31, 2025
06ad11a
works without cafm
bob80905 Nov 4, 2025
ec4e3a9
furthest checkpoint yet
bob80905 Nov 6, 2025
2a49c36
fix up function definition, add TiledResources shader flag
bob80905 Nov 10, 2025
0d0b79f
update tests, make checkaccess inline so it doesn't get auto-emitted …
bob80905 Nov 11, 2025
8cc846b
address Justin
bob80905 Nov 11, 2025
673c1a5
remove spirv intrinsic
bob80905 Nov 11, 2025
3f124ba
address Justin
bob80905 Nov 12, 2025
5bbfc7f
a further simplification
bob80905 Nov 12, 2025
cc885d0
one more nit
bob80905 Nov 12, 2025
84d5ca1
address Helena
bob80905 Nov 20, 2025
1e10b23
Merge branch 'main' into add_load_overload_with_status
bob80905 Nov 20, 2025
48957a3
formatting
bob80905 Nov 20, 2025
5852461
add missing {
bob80905 Nov 20, 2025
4fdb463
address some final nits
bob80905 Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions llvm/lib/Target/DirectX/DXILShaderFlags.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,15 +104,13 @@ static bool checkWaveOps(Intrinsic::ID IID) {
// instruction is ever extracted.
// This is our proof that the module requires TiledResources
// to be set, as if check access fully mapped was used.
bool checkIfStatusIsExtracted(const Instruction *I) {
auto *II = dyn_cast<IntrinsicInst>(I);
assert(II && "intrinsic instruction expected in checkIfStatusIsExtracted");
auto IID = II->getIntrinsicID();
bool checkIfStatusIsExtracted(const IntrinsicInst &II) {
auto IID = II.getIntrinsicID();
Copy link
Contributor

@bogner bogner Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better not to use auto here. Also we probably need [[maybe_unused]] to avoid an unused variable warning in release builds.

assert(IID == Intrinsic::dx_resource_load_typedbuffer ||
IID == Intrinsic::dx_resource_load_rawbuffer &&
"unexpected intrinsic ID, only dx_resource_load_typedbuffer and "
"dx_resource_load_rawbuffer are expected");
for (const User *U : I->users()) {
for (const User *U : II.users()) {
if (const ExtractValueInst *EVI = dyn_cast<ExtractValueInst>(U)) {
// Resource load operations return a {result, status} pair
// check if we extract the status
Expand Down Expand Up @@ -188,7 +186,7 @@ void ModuleShaderFlags::updateFunctionFlags(ComputedShaderFlags &CSF,
}
}

if (auto *II = dyn_cast<IntrinsicInst>(&I)) {
if (const auto *II = dyn_cast<IntrinsicInst>(&I)) {
switch (II->getIntrinsicID()) {
default:
break;
Expand Down Expand Up @@ -216,12 +214,12 @@ void ModuleShaderFlags::updateFunctionFlags(ComputedShaderFlags &CSF,
DRTM[cast<TargetExtType>(II->getArgOperand(0)->getType())];
if (RTI.isTyped())
CSF.TypedUAVLoadAdditionalFormats |= RTI.getTyped().ElementCount > 1;
if (!CSF.TiledResources && checkIfStatusIsExtracted(&I))
if (!CSF.TiledResources && checkIfStatusIsExtracted(*II))
CSF.TiledResources = true;
break;
}
case Intrinsic::dx_resource_load_rawbuffer: {
if (!CSF.TiledResources && checkIfStatusIsExtracted(&I))
if (!CSF.TiledResources && checkIfStatusIsExtracted(*II))
CSF.TiledResources = true;
break;
}
Expand Down
Loading