refactor: Sync with llm-d-kv-cache-manager PR #163 (Update GetPodScores Signature) #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: bongwoobak <bongwoobak@gmail.com> Co-authored-by: Hyeonki Hong <hyeonki.hong@moreh.io> Signed-off-by: HyunKyun Moon <mhg5303@gmail.com>
hyeongyun0916
force-pushed
the
GetPodScores-kv040
branch
from
de9a944 to
2202f3c
Compare
Collaborator
|
@hyeongyun0916 thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The signature of the
GetPodScoresfunction has been updated to align with the changes introduced in llm-d-kv-cache-manager PR #163. This is an essential refactoring to maintain compatibility between KV Cache Manager components.Motivation
The upstream interface for
GetPodScoreswas modified to receive additional message array information. This change is necessary to resolve the API mismatch and secure the stability of the system when interacting with the updated KV Cache Manager.Detailed Changes
The
preprocessing.RenderJinjaTemplateRequestargument has been added to theGetPodScoresfunction signature.AS-IS:
GetPodScores(ctx context.Context, prompt, modelName string, podIdentifiers []string) (map[string]int, error)TO-BE:
GetPodScores(ctx context.Context, renderReq *preprocessing.RenderJinjaTemplateRequest, prompt, modelName string, podIdentifiers []string) (map[string]float64, error)