feat(ci): re-introduce pre-commit fixer workflow but limit autofixes for now #4162
+346
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinb
requested review from
bbrowning,
ehhuang,
franciscojavierarceo,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
slekkala1,
terrytangyuan and
yanxi0830
as code owners
meta-cla
bot
added
the
CLA Signed
ashwinb
changed the title
ashwinb
commented
Nov 14, 2025
| run-name: Apply a subset of pre-commit fixes | ||
|
|
||
| on: | ||
| workflow_dispatch: |
Contributor
Author
There was a problem hiding this comment.
security guardrail #1: manual workflow dispatch
ashwinb
commented
Nov 14, 2025
| fetch-depth: 0 | ||
| persist-credentials: false | ||
|
|
||
| - name: Retrieve trusted pre-commit config |
Contributor
Author
There was a problem hiding this comment.
Security guardrail #2 (but also limitation): don't trust the pre commit config from the PR
ashwinb
commented
Nov 14, 2025
| env: | ||
| GITHUB_TOKEN: '' | ||
|
|
||
| - name: Run trusted pre-commit subset |
Contributor
Author
There was a problem hiding this comment.
Guardrail #3: only run a small subset of pre-commit hooks. Things like "npm ci" have vulnerabilities. We should likely include more of our custom things here but I think like above, should use "main" as the source of truth of the hook.
|
This pull request has merge conflicts that must be resolved before it can be merged. @ashwinb please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.