move starting/stopping GLib event loop into libwebrtc crate #798
+39
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
instead of the screensharing example. This is an implementation detail that users of the library should not need to be concerned about. It is likely this library will be used in cross platform where the developers might not be very familiar with Linux and could overlook the need to run a GLib event loop if they have to handle it on their own.
Contributor
Author
|
Thank you for the quick merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of the screensharing example. This is an implementation detail that users of the library should not need to be concerned about. It is likely this library will be used in cross platform applications where the developers might not be very familiar with Linux and could overlook the need to run a GLib event loop if they have to handle it on their own.