Make useSession().start more stable
#1233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1aab460 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
It had a dependency on `room.connectionState` so that it could bail if the state was the expected state when being initially called, but this had the side effect of causing it to change reference often. So, cache this in a ref instead.
It had a dependency on `state` so that it could bail if the state was the expected state when being initially called, but this had the side effect of causing it to change reference often. So, cache this in a ref instead.
…to make them consistent
1egoman
force-pushed
the
make-use-session-start-more-stable
branch
from
2b07d32 to
4923869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per a note in #1230 (comment), I've made a follow up change which does some work to make
session.starthave a fully stable reference.With these changes, a snippet like the below will now work as expected:
As background context - the reason that
session.start's reference changed so often was because it had a dependency onwaitUntilConnected/agent.waitUntilAvailable, and each of these themselves had dependencies onsession.connectionStateandagent.state, which changed often. There wasn't really much of a con to making a localized copy of this state as a ref so after I did that in both cases the references became stable and those stable references cascaded up to makesession.startstable!