Skip to content

Broadcast audio crash #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Broadcast audio crash #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f720e4
Move engine checks
pblazej Nov 7, 2025
bda70d3
Change
pblazej Nov 7, 2025
01f9dd6
Double check
pblazej Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changes/broadcast-crash
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
patch type="fixed" "Crash when moving apps to background during broadcast"
15 changes: 8 additions & 7 deletions Sources/LiveKit/Audio/MixerEngineObserver.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,13 @@ extension MixerEngineObserver {

// Capture appAudio and apply conversion automatically suitable for internal audio engine.
public func capture(appAudio inputBuffer: AVAudioPCMBuffer) {
guard let converter = converter(for: inputBuffer.format) else {
log("Failed to get converter for input buffer format: \(inputBuffer.format)", .warning)
return
}

let buffer = converter.convert(from: inputBuffer)

let (isConnected, appNode) = _state.read {
($0.isInputConnected, $0.appNode)
}
Expand All @@ -215,15 +222,9 @@ extension MixerEngineObserver {
return
}

// Create or update the converter if needed
let converter = converter(for: inputBuffer.format)

guard let converter else { return }

let buffer = converter.convert(from: inputBuffer)
appNode.scheduleBuffer(buffer)

if !appNode.isPlaying {
if !appNode.isPlaying, let engine = appNode.engine, engine.isRunning {
appNode.play()
}
}
Expand Down
Loading