Skip to content

Check that input is a tty before using it #4416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+26 −7
Open

Check that input is a tty before using it #4416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a4a3dd
Check tty flag also for the shell command
afbjorklund Nov 30, 2025
f6b6326
Check that input is a tty before using it
afbjorklund Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/limactl/clone.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func cloneOrRenameAction(cmd *cobra.Command, args []string) error {
}

if tty && !flags.Changed("start") {
start, err = askWhetherToStart()
start, err = askWhetherToStart(cmd)
if err != nil {
return err
}
Expand Down
12 changes: 8 additions & 4 deletions cmd/limactl/edit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ func editAction(cmd *cobra.Command, args []string) error {
}

if tty && !flags.Changed("start") {
start, err = askWhetherToStart()
start, err = askWhetherToStart(cmd)
if err != nil {
return err
}
Expand All @@ -180,9 +180,13 @@ func editAction(cmd *cobra.Command, args []string) error {
return instance.Start(ctx, inst, false, false)
}

func askWhetherToStart() (bool, error) {
message := "Do you want to start the instance now? "
return uiutil.Confirm(message, true)
func askWhetherToStart(cmd *cobra.Command) (bool, error) {
isTTY := uiutil.InputIsTTY(cmd.InOrStdin())
if isTTY {
message := "Do you want to start the instance now? "
return uiutil.Confirm(message, true)
}
return false, nil
}

func editBashComplete(cmd *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
Expand Down
8 changes: 6 additions & 2 deletions cmd/limactl/shell.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ func newShellCommand() *cobra.Command {
func shellAction(cmd *cobra.Command, args []string) error {
ctx := cmd.Context()
flags := cmd.Flags()
tty, err := flags.GetBool("tty")
if err != nil {
return err
}
// simulate the behavior of double dash
newArg := []string{}
if len(args) >= 2 && args[1] == "--" {
Expand Down Expand Up @@ -100,8 +104,8 @@ func shellAction(cmd *cobra.Command, args []string) error {
return err
}

if !flags.Changed("start") {
startNow, err = askWhetherToStart()
if tty && !flags.Changed("start") {
startNow, err = askWhetherToStart(cmd)
if err != nil {
return err
}
Expand Down
11 changes: 11 additions & 0 deletions pkg/uiutil/uiutil.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,17 @@ func Select(message string, options []string) (int, error) {
return ans, nil
}

// InputIsTTY returns true if reader is coming from stdin, and stdin is a terminal device,
// not a regular file, stream, or pipe etc.
func InputIsTTY(reader io.Reader) bool {
// This setting is needed so we can write integration tests for the TTY input.
Copy link
Member

@AkihiroSuda AkihiroSuda Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test seems missing?

// It is probably not useful otherwise.
if os.Getenv("_LIMA_INPUT_IS_TTY") != "" {
return true
}
return reader == os.Stdin && (isatty.IsTerminal(os.Stdin.Fd()) || isatty.IsCygwinTerminal(os.Stdin.Fd()))
}

// OutputIsTTY returns true if writer is going to stdout, and stdout is a terminal device,
// not a regular file, stream, or pipe etc.
func OutputIsTTY(writer io.Writer) bool {
Expand Down
Loading