java_options allows to set custom parameters

Author: igorblr

chart/templates/backend-deployment.yaml

@@ -147,7 +147,6 @@ spec:
 {{- $envs := .Values.deployments.backend.extraEnvs | default (list) -}}
 {{- $memMi := include "mem-to-mi" (.Values.deployments.backend.resources.memory | default "") | int -}}
 {{- $javaVal := (include "get-env" (list $envs "_JAVA_OPTIONS") | trim) -}}
-
 {{- /* start with user extraEnvs, but drop _JAVA_OPTIONS */ -}}
 {{- $rendered := list -}}
 {{- range $e := $envs -}}

chart/templates/helpers/_helpers.tpl

@@ -974,8 +974,7 @@ Cron-specific asyncProfiler helpers
 {{- end -}}
 
 {{/*
-Merge extraEnvs from backend and crons with crons taking precedence for duplicate keys.
-JAVA options are intentionally filtered out and should be added explicitly by templates.
+Merge extraEnvs from backend and crons with crons taking precedence for duplicate keys
 */}}
 {{- define "lightrun-crons.mergedExtraEnvs" -}}
 {{- $backendExtraEnvs := .Values.deployments.backend.extraEnvs | default list -}}
@@ -994,17 +993,13 @@ JAVA options are intentionally filtered out and should be added explicitly by te
 {{- end -}}
 {{/* Only add backend env if not overridden by crons */}}
 {{- if not $isOverridden -}}
-{{- if and (ne $backendEnv.name "_JAVA_OPTIONS") (ne $backendEnv.name "JAVA_OPTIONS") -}}
-    {{- $mergedEnvs = append $mergedEnvs $backendEnv -}}
-  {{- end -}}
+{{- $mergedEnvs = append $mergedEnvs $backendEnv -}}
 {{- end -}}
 {{- end -}}
 
 {{/* Then, add all crons extraEnvs (these take precedence) */}}
 {{- range $cronsExtraEnvs -}}
-{{- if and (ne .name "_JAVA_OPTIONS") (ne .name "JAVA_OPTIONS") -}}
-    {{- $mergedEnvs = append $mergedEnvs . -}}
-  {{- end -}}
+{{- $mergedEnvs = append $mergedEnvs . -}}
 {{- end -}}
 
 {{/* Output merged envs as YAML if any exist */}}
@@ -1013,20 +1008,6 @@ JAVA options are intentionally filtered out and should be added explicitly by te
 {{- end -}}
 {{- end -}}
 
-
-{{/* Get merged JAVA options from backend+crons with crons taking precedence */}}
-{{- define "lightrun-crons.getMergedJavaOptions" -}}
-{{- $backendExtraEnvs := .Values.deployments.backend.extraEnvs | default list -}}
-{{- $cronsExtraEnvs := .Values.deployments.crons.extraEnvs | default list -}}
-{{- $opts := include "get-java-options-from-envs" $backendExtraEnvs -}}
-{{- $cronsOpts := include "get-java-options-from-envs" $cronsExtraEnvs -}}
-{{- if $cronsOpts -}}
-{{- $cronsOpts -}}
-{{- else -}}
-{{- $opts -}}
-{{- end -}}
-{{- end -}}
-
 {{/*
 ################
 ### Datadog  ###

chart/templates/keycloak-statefulset.yaml

@@ -13,8 +13,6 @@ spec:
   serviceName: {{ include "lightrun-keycloak.name" . }}
   updateStrategy:
     type: RollingUpdate
-  # For clusters with more than 3 pods, consider changing the number of "owner nodes" as described in
-  # https://www.keycloak.org/server/caching#_configuring_caches -> Configuring caches for availability
   replicas: {{ .Values.deployments.keycloak.replicas }}
   selector:
     matchLabels: