Skip to content

Commit 29a2ad4

Browse files
committed
javaooptions changes
1 parent 6848386 commit 29a2ad4

File tree

1 file changed

+22
-3
lines changed

1 file changed

+22
-3
lines changed

chart/templates/helpers/_helpers.tpl

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -974,7 +974,8 @@ Cron-specific asyncProfiler helpers
974974
{{- end -}}
975975

976976
{{/*
977-
Merge extraEnvs from backend and crons with crons taking precedence for duplicate keys
977+
Merge extraEnvs from backend and crons with crons taking precedence for duplicate keys.
978+
JAVA options are intentionally filtered out and should be added explicitly by templates.
978979
*/}}
979980
{{- define "lightrun-crons.mergedExtraEnvs" -}}
980981
{{- $backendExtraEnvs := .Values.deployments.backend.extraEnvs | default list -}}
@@ -993,13 +994,17 @@ Merge extraEnvs from backend and crons with crons taking precedence for duplicat
993994
{{- end -}}
994995
{{/* Only add backend env if not overridden by crons */}}
995996
{{- if not $isOverridden -}}
996-
{{- $mergedEnvs = append $mergedEnvs $backendEnv -}}
997+
{{- if and (ne $backendEnv.name "_JAVA_OPTIONS") (ne $backendEnv.name "JAVA_OPTIONS") -}}
998+
{{- $mergedEnvs = append $mergedEnvs $backendEnv -}}
999+
{{- end -}}
9971000
{{- end -}}
9981001
{{- end -}}
9991002

10001003
{{/* Then, add all crons extraEnvs (these take precedence) */}}
10011004
{{- range $cronsExtraEnvs -}}
1002-
{{- $mergedEnvs = append $mergedEnvs . -}}
1005+
{{- if and (ne .name "_JAVA_OPTIONS") (ne .name "JAVA_OPTIONS") -}}
1006+
{{- $mergedEnvs = append $mergedEnvs . -}}
1007+
{{- end -}}
10031008
{{- end -}}
10041009

10051010
{{/* Output merged envs as YAML if any exist */}}
@@ -1008,6 +1013,20 @@ Merge extraEnvs from backend and crons with crons taking precedence for duplicat
10081013
{{- end -}}
10091014
{{- end -}}
10101015

1016+
1017+
{{/* Get merged JAVA options from backend+crons with crons taking precedence */}}
1018+
{{- define "lightrun-crons.getMergedJavaOptions" -}}
1019+
{{- $backendExtraEnvs := .Values.deployments.backend.extraEnvs | default list -}}
1020+
{{- $cronsExtraEnvs := .Values.deployments.crons.extraEnvs | default list -}}
1021+
{{- $opts := include "get-java-options-from-envs" $backendExtraEnvs -}}
1022+
{{- $cronsOpts := include "get-java-options-from-envs" $cronsExtraEnvs -}}
1023+
{{- if $cronsOpts -}}
1024+
{{- $cronsOpts -}}
1025+
{{- else -}}
1026+
{{- $opts -}}
1027+
{{- end -}}
1028+
{{- end -}}
1029+
10111030
{{/*
10121031
################
10131032
### Datadog ###

0 commit comments

Comments
 (0)