[Part 7|*] Addressing TODOs left from the SQL payments implementation #10373
+1,011
−584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziggie1984
changed the base branch from
master
to
elle-payment-sql-series-new
ziggie1984
force-pushed
the
introduce-sql-schema-payments-part-7
branch
from
e00c320 to
4f1babb
Compare
ziggie1984
force-pushed
the
introduce-sql-schema-payments-part-7
branch
from
4f1babb to
a6c9e12
Compare
ziggie1984
force-pushed
the
elle-payment-sql-series-new
branch
2 times, most recently
from
47606dd to
01d9986
Compare
8 tasks
ziggie1984
force-pushed
the
introduce-sql-schema-payments-part-7
branch
from
a6c9e12 to
d543390
Compare
Collaborator
Author
|
Converage of the SQL store after this PR is merged: |
A context is added to failPaymentAndAttempt and its dependant function calls.
We make the TestDeleteNonInFlight and separate all the logic out for the duplicate payment test case. The deletion of duplicate payments is now tested in isolation only for the kv backend.
Previously we had db and application logic mixed on the db level. We now move the config option KeepFailedPaymentAttempts to the ChannelRouter level and move it out of the db level.
We add a test which tests the retrieval of first hop data like the first hop amount or the custom records on the route level.
We add a couple of additional tests to increase the unit test coverage of the sql store but also the kv store. We only create db agnostic unit tests so both backends are tested effectively.
ziggie1984
force-pushed
the
introduce-sql-schema-payments-part-7
branch
from
2e6f53f to
fb82814
Compare
yyforyongyu
approved these changes
Dec 2, 2025
Member
yyforyongyu
left a comment
yyforyongyu
left a comment
There was a problem hiding this comment.
LGTM
We still have this question from Part 6, where we need to decide whether we need to use a timeout ctx or not?
| log.Debugf("Scanning finished, found %d inflight payments", | ||
| len(payments)) | ||
|
|
||
| // TODO(ziggie): Also check for payments which have no HTLCs at all |
Member
There was a problem hiding this comment.
Why do we want to delete it? I think the payment in this case can be retried?
| "%v: %v", p.identifier, err) | ||
| // Optionally delete the failed attempts from the database. If we are | ||
| // configured to keep failed payment attempts, we skip deletion. | ||
| if !p.router.cfg.KeepFailedPaymentAttempts { |
| // called based on the configuration. | ||
| if tc.expectDeleteCalled { | ||
| m.control.On("DeleteFailedAttempts", | ||
| p.identifier).Return(nil).Once() |
|
|
||
| // Conditionally expect DeleteFailedAttempts to be | ||
| // called based on the configuration. | ||
| if tc.expectDeleteCalled { |
Member
There was a problem hiding this comment.
nit: can use !tc.keepFailedPaymentAttempts
ellemouton
approved these changes
Dec 3, 2025
| "%v: %v", p.identifier, err) | ||
| // Optionally delete the failed attempts from the database. If we are | ||
| // configured to keep failed payment attempts, we skip deletion. | ||
| if !p.router.cfg.KeepFailedPaymentAttempts { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleansup some TODOs of the payment sql series, before tackling the dispatcher and the migration.