-
Notifications
You must be signed in to change notification settings - Fork 421
Bindings doc updates for 0.2 #4203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
16aabce
7fb0f2a
2bf737c
3f82fd6
b07111e
8eabcc1
126ac50
c311447
b55eec7
9516400
4bc993c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -94,27 +94,39 @@ pub(crate) fn dummy_waker() -> Waker { | |
|
|
||
| #[cfg(feature = "std")] | ||
| /// A type alias for a future that returns a result of type `T` or error `E`. | ||
| /// | ||
| /// This is not exported to bindings users as async is only supported in Rust. | ||
| pub type AsyncResult<'a, T, E> = Pin<Box<dyn Future<Output = Result<T, E>> + 'a + Send>>; | ||
| #[cfg(not(feature = "std"))] | ||
| /// A type alias for a future that returns a result of type `T` or error `E`. | ||
| /// | ||
| /// This is not exported to bindings users as async is only supported in Rust. | ||
| pub type AsyncResult<'a, T, E> = Pin<Box<dyn Future<Output = Result<T, E>> + 'a>>; | ||
|
|
||
| /// Marker trait to optionally implement `Sync` under std. | ||
| /// | ||
| /// This is not exported to bindings users as async is only supported in Rust. | ||
| #[cfg(feature = "std")] | ||
| pub use core::marker::Sync as MaybeSync; | ||
|
|
||
| #[cfg(not(feature = "std"))] | ||
| /// Marker trait to optionally implement `Sync` under std. | ||
| /// | ||
| /// This is not exported to bindings users as async is only supported in Rust. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Out of scope: some of the
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice, yea, would be good to go back and remove what we can now.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. MIssing the hypothetical rust 'unnecessary bound' warning. |
||
| pub trait MaybeSync {} | ||
| #[cfg(not(feature = "std"))] | ||
| impl<T> MaybeSync for T where T: ?Sized {} | ||
|
|
||
| /// Marker trait to optionally implement `Send` under std. | ||
| /// | ||
| /// This is not exported to bindings users as async is only supported in Rust. | ||
| #[cfg(feature = "std")] | ||
| pub use core::marker::Send as MaybeSend; | ||
|
|
||
| #[cfg(not(feature = "std"))] | ||
| /// Marker trait to optionally implement `Send` under std. | ||
| /// | ||
| /// This is not exported to bindings users as async is only supported in Rust. | ||
| pub trait MaybeSend {} | ||
| #[cfg(not(feature = "std"))] | ||
| impl<T> MaybeSend for T where T: ?Sized {} | ||
Uh oh!
There was an error while loading. Please reload this page.