Skip to content

Bindings doc updates for 0.2 #4203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 4, 2025
+276 −29
Merged

Bindings doc updates for 0.2 #4203

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
16aabce
Mark `CheckedHrpstringError` instances as no-export
TheBlueMatt Dec 28, 2024
7fb0f2a
Mark BOLT 12 builders no-export in the new `OffersMessageFlow`
TheBlueMatt Nov 3, 2025
2bf737c
Require the high-level sign traits instead of `SignFn` in bindings
TheBlueMatt Nov 3, 2025
3f82fd6
Mark async traits and structs no-export
TheBlueMatt Nov 3, 2025
b07111e
Import `ChannelTransactionParameters` from its real path
TheBlueMatt Nov 3, 2025
8eabcc1
Copy no-export tags to new serialization traits
TheBlueMatt Nov 3, 2025
126ac50
`use` `Vec` from `alloc` rather than the crate prelude
TheBlueMatt Nov 3, 2025
c311447
Copy async docs from async bump transaction objects to sync ones
TheBlueMatt Nov 3, 2025
b55eec7
Provide the same docs in `ChangeDestinationSource` as the sync one
TheBlueMatt Nov 3, 2025
9516400
Copy async docs from async KVStore to sync one
TheBlueMatt Nov 3, 2025
4bc993c
Copy docs from `OutputSweeper` to `OutputSweeperSync`
TheBlueMatt Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lightning-invoice/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,10 @@ use crate::ser::Base32Iterable;
#[allow(missing_docs)]
#[derive(PartialEq, Eq, Debug, Clone)]
pub enum Bolt11ParseError {
Bech32Error(CheckedHrpstringError),
Bech32Error(
/// This is not exported to bindings users as the details don't matter much
CheckedHrpstringError,
),
ParseAmountError(ParseIntError),
MalformedSignature(bitcoin::secp256k1::Error),
BadPrefix,
Expand Down
5 changes: 4 additions & 1 deletion lightning/src/offers/parse.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,10 @@ pub enum Bolt12ParseError {
/// being parsed.
InvalidBech32Hrp,
/// The string could not be bech32 decoded.
Bech32(CheckedHrpstringError),
Bech32(
/// This is not exported to bindings users as the details don't matter much
CheckedHrpstringError,
),
/// The bech32 decoded string could not be decoded as the expected message type.
Decode(DecodeError),
/// The parsed message has invalid semantics.
Expand Down