Fix the full_stack_target breakage test and doc feerate requests
#3046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we added the additional deust exposure checks in 702196819e6445048b803574fcacef77d5ce8c9c we added several additional feerate fetches which broke the `full_stack_target` change-detection test. This updates the hard-coded test to support the new feerate fetches and also includes a comment on `FeeEstimator` to indicate that users really need to be caching feerates as otherwise they'll slow us down.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3046 +/- ##
==========================================
+ Coverage 89.82% 89.83% +0.01%
==========================================
Files 116 116
Lines 96259 96259
Branches 96259 96259
==========================================
+ Hits 86465 86476 +11
+ Misses 7235 7217 -18
- Partials 2559 2566 +7 ☔ View full report in Codecov by Sentry. |
valentinewallace
approved these changes
May 7, 2024
Contributor
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
Oh full stack target
Collaborator
Author
|
Just test and doc changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we added the additional deust exposure checks in 702196819e6445048b803574fcacef77d5ce8c9c we added several additional feerate fetches which broke the
full_stack_targetchange-detection test.This updates the hard-coded test to support the new feerate fetches and also includes a comment on
FeeEstimatorto indicate that users really need to be caching feerates as otherwise they'll slow us down.