UniFFI bindings #25
UniFFI bindings #25
Conversation
tnull
force-pushed
the
2022-09-start-uniffi
branch
7 times, most recently
from
933cc5c to
7eb0707
Compare
tnull
force-pushed
the
2022-09-start-uniffi
branch
2 times, most recently
from
78e2f18 to
f4df595
Compare
|
Rebased on current state of #11. |
tnull
force-pushed
the
2022-09-start-uniffi
branch
from
f4df595 to
45c7724
Compare
tnull
force-pushed
the
2022-09-start-uniffi
branch
3 times, most recently
from
b7622d9 to
4b449b4
Compare
|
Rebased on #11. |
tnull
force-pushed
the
2022-09-start-uniffi
branch
5 times, most recently
from
a364bb0 to
2d9fe37
Compare
tnull
force-pushed
the
2022-09-start-uniffi
branch
3 times, most recently
from
8481816 to
1b70183
Compare
tnull
force-pushed
the
2022-09-start-uniffi
branch
2 times, most recently
from
32d3675 to
4fcfebc
Compare
tnull
force-pushed
the
2022-09-start-uniffi
branch
from
7921080 to
40c5031
Compare
tnull
force-pushed
the
2022-09-start-uniffi
branch
from
49f7f59 to
dfad7f1
Compare
|
Squashed fixups and rebased. Dropped part of the last WIP commit, as this is getting too big anyways. We should land this and then add CI bindings testing in a follow-up. |
tnull
force-pushed
the
2022-09-start-uniffi
branch
from
dfad7f1 to
13ab9b6
Compare
|
Rebased on main. |
jkczyz
left a comment
jkczyz
left a comment
There was a problem hiding this comment.
Are the "bindings generation support" commits generated from somewhere?
tnull
force-pushed
the
2022-09-start-uniffi
branch
3 times, most recently
from
b4fecbb to
8cf01a0
Compare
| val address2 = node2.newFundingAddress() | ||
| println("Funding address 2: $address2") | ||
|
|
||
| //sendToAddress(address1, 100000u) |
There was a problem hiding this comment.
Any reason why this is commented out?
There was a problem hiding this comment.
Yes, as the way I'm issuing commands to the bitcoind regtest node in the JVM version doesn't work on Android (no bitcoin-cli available there, and not even the Runtime JVM object I use to run the commands) . So it's still WIP how to actually integrate the Android library tests with a) any bitcoind/electrsd backend b) run them in the Android device simulator and c) run all of it in CI.
All of it will be a bunch of work that I don't expect to land in this PR, very likely not even for 0.1. I now dropped the commented-out parts and would defer any further changes to a dedicated follow-up.
bindings/kotlin/ldk-node-jvm/lib/src/test/kotlin/org/lightningdevkit/ldknode/LibraryTest.kt
Outdated
Show resolved
Hide resolved
tnull
force-pushed
the
2022-09-start-uniffi
branch
3 times, most recently
from
58d6868 to
ea53a29
Compare
jkczyz
left a comment
jkczyz
left a comment
There was a problem hiding this comment.
LGTM. Please squash fix-ups.
We generate the scaffolding from an UDL file and include it in `lib.rs`. Furthermore, we add a bindings generation shell script for convenience.
tnull
force-pushed
the
2022-09-start-uniffi
branch
from
ea53a29 to
cf92ff1
Compare
Squashed without further changes. |
4 participants
Based on
#9,#10,#11,#13,#52.This PR provides the starting point for UniFFI bindings. Depending on how much code changes are required for the binding generation, we may want to move this to a separate repository.