-
Notifications
You must be signed in to change notification settings - Fork 78
Кондаков Владислав. Технология SEQ-MPI. Нахождение минимальных значений по строкам матрицы. Вариант 17 #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Кондаков Владислав. Технология SEQ-MPI. Нахождение минимальных значений по строкам матрицы. Вариант 17 #105
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 94.03% 94.25% +0.22%
==========================================
Files 15 17 +2
Lines 486 592 +106
Branches 181 233 +52
==========================================
+ Hits 457 558 +101
- Misses 0 2 +2
- Partials 29 32 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| size_t cols = matrix[0].size(); | ||
| // NOLINTNEXTLINE(readability-use-anyofallof) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, do not use NOLINTNEXTLINE(readability-use-anyofallof) in both occurrences
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
|
||
| size_t total_rows = 0; | ||
| size_t cols = 0; | ||
| BroadcastMatrixMetadata(in_data, total_rows, cols); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, split the matrix and send only relevant parts from rank 0 to other ranks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Описание
Чек-лист
<фамилия>_<первая_буква_имени>_<короткое_название_задачи>clang-formatлокально в моем форке (нет ошибок форматирования)clang-tidyлокально в моем форке (нет предупреждений/ошибок)nesterov_a_vector_sum), а не вmaster