Skip to content

Use CMake's Sphinx detection #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Use CMake's Sphinx detection #594

wants to merge 2 commits into from

Conversation

@aobolensk
Copy link
Member

@aobolensk aobolensk commented Aug 1, 2025 •
edited
Loading

  • detect Sphinx with find_package()
  • keep old variables but populated from the module

@aobolensk aobolensk requested a review from allnes as a code owner August 1, 2025 15:45
@allnes allnes enabled auto-merge August 1, 2025 15:46
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

Coverage report is available for download
here

@codecov
Copy link

codecov bot commented Aug 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.24%. Comparing base (ccc6db9) to head (a604bbc).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #594   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files          11       11           
  Lines         373      373           
  Branches      130      130           
=======================================
  Hits          359      359           
  Partials       14       14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@allnes allnes added this pull request to the merge queue Aug 1, 2025
@allnes allnes removed this pull request from the merge queue due to a manual request Aug 1, 2025
@aobolensk aobolensk enabled auto-merge August 1, 2025 17:43
@allnes
Copy link
Member

allnes commented Aug 3, 2025

@aobolensk

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2025

Coverage report is available for download
here

@aobolensk
Copy link
Member Author

aobolensk commented Aug 3, 2025

It seems the other solution is going to be too verbose, closing

@aobolensk aobolensk closed this Aug 3, 2025
auto-merge was automatically disabled August 3, 2025 11:40

Pull request was closed

@aobolensk aobolensk deleted the codex/detect-sphinx-with-find_package branch August 4, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allnes allnes allnes approved these changes

Assignees

No one assigned

Labels

codex infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aobolensk @allnes