-
Notifications
You must be signed in to change notification settings - Fork 344
feat(genai): support optional seed parameter
#1356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(genai): support optional seed parameter
#1356
Conversation
mdrxy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add unit tests?
seed parameter
|
bump @Odessit007 |
|
Hi @mdrxy. I've been sick since last week. I should have time in the next few days to have a look. Initially I didn't add tests because I noticed that there are no tests for Now that you requested, I'm going to add a simple integration test marked as flaky with 3-5 retries similar to existing tests. Also, maybe a unit test to check that the parameter is properly set. |
|
gotcha thanks! hope you're doing better deferring this PR until after the SDK consolidation takes place |
Description
Support an optional
seedparameter that Google Gen AI SDK exposes for more reproducible generations but langchain-google-genai currently doesn't support.Relevant issues
Closes #1355
Type
🆕 New Feature