Skip to content

chore(transcript): make sample_u64 advancing via sample bytes #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(transcript): make sample_u64 advancing via sample bytes #1021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d0fa16
chore(transcript): make sample_u64 advancing via sample bytes
radik878 Sep 1, 2025
823c83d
chore(transcript): make sample_u64 advancing via sample bytes
radik878 Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crates/crypto/src/fiat_shamir/default_transcript.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ where
}

fn sample_u64(&mut self, upper_bound: u64) -> u64 {
u64::from_be_bytes(self.state()[..8].try_into().unwrap()) % upper_bound
let mut bytes = [0u8; 8];
bytes.copy_from_slice(&self.sample()[..8]);
u64::from_be_bytes(bytes) % upper_bound
}
}

Expand Down
10 changes: 8 additions & 2 deletions crates/provers/winterfell_adapter/src/adapter/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ impl IsStarkTranscript<Felt> for FeltTranscript {
}

fn sample_u64(&mut self, upper_bound: u64) -> u64 {
u64::from_be_bytes(self.state()[..8].try_into().unwrap()) % upper_bound
let bytes = self.sample(8);
let mut arr = [0u8; 8];
arr.copy_from_slice(&bytes);
u64::from_be_bytes(arr) % upper_bound
}
}

Expand Down Expand Up @@ -82,6 +85,9 @@ impl IsStarkTranscript<QuadFelt> for QuadFeltTranscript {
}

fn sample_u64(&mut self, upper_bound: u64) -> u64 {
u64::from_be_bytes(self.state()[..8].try_into().unwrap()) % upper_bound
let bytes = self.felt_transcript.sample(8);
let mut arr = [0u8; 8];
arr.copy_from_slice(&bytes);
u64::from_be_bytes(arr) % upper_bound
}
}