-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Update base images and dependencies to address vulnerabilities #35968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @prad9192! |
|
Hi @prad9192. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@prad9192: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Prow isn't built here anymore, I'm not sure if we should just be deleting these images now. If your goal is to patch prow, this may not be the solution. see sigs.k8s.io/prow cc @petr-muller |
|
Hi @BenTheElder Thanks for your review, I see that Prow depends on base images which are sourced from this repo. PR updates the source Dockerfiles that build And having these updated images would allow me to open a follow up PR to make updates to base images referenced in prow |
|
/hold We should merge #35799 and create an autobumper config in the prow repo to pick up the new images automaticall.y |
| # Prefer 0.5.x series (not 0.6.x) for now. | ||
| _AWS_IAM_AUTHENTICATOR_VERSION: "0.5.21" | ||
| _AZURE_KUBELOGIN_VERSION: "0.1.4" | ||
| _AWS_IAM_AUTHENTICATOR_VERSION: "0.7.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please drop all the changes except this file and I'll approve this PR and delete the comment below _GIT_TAG:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, could you please re-review?
upodroid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
/hold cancel
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prad9192, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ACK ... that's been messy since prow was split out of this repo :-) In most cases prow does not depend on this repo anymore, and shouldn't For the images only used by prow, we should probably move them for clarity, but it's not important. This directory is highly overloaded and the other images have other considerations ... |
What
Updates Alpine base images and related dependencies
Why
To fix multiple security vulnerabilities
Release Notes