Skip to content

Conversation

@aojea
Copy link
Member

@aojea aojea commented Oct 14, 2025

update from #296

  • Incorporated feedback from @soltysh
  • Added more details about the verification process, to include that the claims should be backed up by public artifacts

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 14, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2025
@aojea aojea requested review from a team and removed request for pohly and saschagrunert October 14, 2025 08:49
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 14, 2025
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, but overall

/lgtm

/hold
for other steering members to review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2025
Co-authored-by: Maciej Szulik <soltysh@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2025
@pacoxu
Copy link
Member

pacoxu commented Oct 29, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2025
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, pacoxu, pohly, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [aojea,pacoxu,pohly,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


* The letter is considered officially approved once the [required majority] has
signed it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no guidance on what happens if a request is denied or what makes a request unsuitable. Like:

## Handling of Requests

### Approval Criteria

The Steering Committee will approve requests when:

- All submitted materials are complete and accurate
- Claims are substantiated by public artifacts
- Peer verification confirms factual accuracy
- Contributions align with Kubernetes project values

### If a Request is Not Approved

- Applicant will receive written feedback explaining the decision
- Applicant may resubmit after addressing concerns
- Confidentiality of the original request is maintained

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to keep the process simple, the approval criteria is clear, is signed by at least 4 members, whatever the existing members consider necessary ... for not approved I would also suggest to not be very prescriptive, we are setting a process to get more organized, but these decisions will impact different steering committees across the years that will need to handle different situations and social environments

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we want to reach the approval, the only reason for not receiving one is not meeting the criteria. So it's not about rejection per se, but rather not meeting the criteria, in which case that's the answer the requester will receive.

materials, copying <steering-private@kubernetes.io>. This ensures the entire
conversation history is maintained in a single thread.

* Members who are satisfied with the letter's accuracy and tone proceed to sign
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are the signatures provided? electronically?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we've managed to pull it off last time electronically. We've started conversations with CNCF about providing a platform for this in the long run.

@pacoxu
Copy link
Member

pacoxu commented Dec 4, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit b737b8a into kubernetes:main Dec 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants