-
Notifications
You must be signed in to change notification settings - Fork 65
Add process for Contributor Recommendation Letters #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
soltysh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit, but overall
/lgtm
/hold
for other steering members to review
Co-authored-by: Maciej Szulik <soltysh@gmail.com>
|
/lgtm |
pohly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, pacoxu, pohly, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| * The letter is considered officially approved once the [required majority] has | ||
| signed it. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no guidance on what happens if a request is denied or what makes a request unsuitable. Like:
## Handling of Requests
### Approval Criteria
The Steering Committee will approve requests when:
- All submitted materials are complete and accurate
- Claims are substantiated by public artifacts
- Peer verification confirms factual accuracy
- Contributions align with Kubernetes project values
### If a Request is Not Approved
- Applicant will receive written feedback explaining the decision
- Applicant may resubmit after addressing concerns
- Confidentiality of the original request is maintainedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to keep the process simple, the approval criteria is clear, is signed by at least 4 members, whatever the existing members consider necessary ... for not approved I would also suggest to not be very prescriptive, we are setting a process to get more organized, but these decisions will impact different steering committees across the years that will need to handle different situations and social environments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we want to reach the approval, the only reason for not receiving one is not meeting the criteria. So it's not about rejection per se, but rather not meeting the criteria, in which case that's the answer the requester will receive.
| materials, copying <steering-private@kubernetes.io>. This ensures the entire | ||
| conversation history is maintained in a single thread. | ||
|
|
||
| * Members who are satisfied with the letter's accuracy and tone proceed to sign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are the signatures provided? electronically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we've managed to pull it off last time electronically. We've started conversations with CNCF about providing a platform for this in the long run.
|
/unhold |
update from #296