-
Notifications
You must be signed in to change notification settings - Fork 357
ci/gomod: added CI steps to check Golang directive #1283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
|
This issue is currently awaiting triage. If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8ed2bf8 to
b01b3e5
Compare
|
/test all |
8c065f9 to
d0421f5
Compare
elmiko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes sense to me
d0421f5 to
7f33f89
Compare
|
/test pull-cloud-provider-aws-check |
|
pull-cloud-provider-aws-check is not reporting as expected, the new make command failed and it report as pass: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/cloud-provider-aws/1283/pull-cloud-provider-aws-check/1981728404394741760#1:build-log.txt%3A143 Suggested action items:
|
Not sure if I am looking at the correct place, looks like the |
7f33f89 to
ef7d44f
Compare
|
/retest |
Introduce the step to validate if the go.mod is in conformance with Kubernetes project standard by using the patch version from the build env (ending with .0, x.y.0).
ef7d44f to
13eba60
Compare
|
PR ready for review based in the step gomod-dotzero-check logs: |
damdo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
Co-authored-by: Damiano Donati <damiano.donati@gmail.com>
|
CI infra issues in job test. /retest |
damdo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
elmiko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kmala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Introduce CI step to validate the Go directive is according to the standard used in kubernetes project (ending with .0, x.y.0).
The step introduces the command
verify-go-directivewhich will use a common script from cluster-api project to verify the directive is in conformance with the project standard.Please leave a comment with your thoughts of which option would be ok to follow the practice by this project.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The command is executed both in Github Actions and Prow, where Github Actions is handling correctly the exit code.
Does this PR introduce a user-facing change?: