Add conformance report for Contour 1.33.0 and Gateway API 1.3.0 #4076
Conversation
Signed-off-by: Sunjay Bhatia <sunjay.bhatia@broadcom.com>
k8s-ci-robot
added
release-note-none
|
cc @kubernetes-sigs/gateway-api-maintainers |
| skippedTests: | ||
| - GatewayStaticAddresses | ||
| - HTTPRouteInvalidParentRefSectionNameNotMatchingPort | ||
| - HTTPRouteRedirectPortAndScheme |
There was a problem hiding this comment.
Instead of skipping tests can you just change the set of features you claim to support?
There was a problem hiding this comment.
@robscott I did re-run conformance with unsupported features rather than specific skipped tests, though it does mean some tests that do pass are not run/documented as such any longer
Hoping to cover all of these in our next release and with 1.4.0 conformance so not a huge deal
There was a problem hiding this comment.
I wasn't able to stop skipping the HTTPRouteHTTPSListener test as there is no specific feature associated with the test, it would mean skipping all HTTPRoute tests which is not ideal of course
Signed-off-by: Sunjay Bhatia <sunjay.bhatia@broadcom.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sunjayBhatia The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| - core: | ||
| result: partial | ||
| skippedTests: | ||
| - HTTPRouteHTTPSListener |
There was a problem hiding this comment.
had to leave this as a skipped test since there is not a specific enough feature to disable this one test (otherwise we would have to disable testing HTTPRoute in general), this should be addressed in the next release however to remove the skip entirely
| unsupportedFeatures: | ||
| - GatewayStaticAddresses | ||
| - HTTPRouteParentRefPort | ||
| - HTTPRoutePortRedirect |
There was a problem hiding this comment.
note: passing HTTPRouteParentRefPort and HTTPRoutePortRedirect as unsupported means we're now skipping running some tests that do pass, the specific tests that were previously skipped are HTTPRouteRedirectPortAndScheme and HTTPRouteInvalidParentRefSectionNameNotMatchingPort
3 participants
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Adds conformance report for new Contour 1.33.0 release which supports Gateway API 1.3.0
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: