Skip to content

Conversation

@arshadd-b
Copy link
Contributor

What this PR does / why we need it:
Bump GoVersion to 1.24.9
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Nov 7, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 7, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 7, 2025
@sbueringer sbueringer added the area/dependency Issues or PRs related to dependency changes label Nov 7, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Nov 7, 2025
@arshadd-b arshadd-b changed the title 🌱 [release-1.9] Bump go version to 1.24.9 🌱 [release-1.9] Bump go version to 1.24.10 Nov 7, 2025
@arshadd-b
Copy link
Contributor Author

looks like lot of lint issues , thinking to increase the golint version to 1.61 and check

@sbueringer
Copy link
Member

Hm almost look like compile issues

In general I would be fine with adding excludes instead of fixing lint findings

@sbueringer
Copy link
Member

sbueringer commented Nov 7, 2025

Tested v1.64.3, looks better. Let's bump to v1.64.3. But please let's make only the same fixes we made on release-1.10 + some additional ones in unit test files are fine.

If there are more findings, let's use //nolint: for them

@arshadd-b
Copy link
Contributor Author

Tested v1.64.3, looks better. Let's bump to v1.64.3. But please let's make only the same fixes we made on release-1.10 + some additional ones in unit test files are fine.

If there are more findings, let's use //nolint: for them

sure

@sbueringer
Copy link
Member

@arshadd-b Let's add excludes for the remaining findings to .golangci.yml

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 10, 2025
@arshadd-b arshadd-b force-pushed the update-goversion branch 2 times, most recently from 63348a9 to e8e7425 Compare November 10, 2025 13:36
@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 10, 2025
@sbueringer
Copy link
Member

Thank you very much!!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 10, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: da8f972d656da4e83f0deebcf31829e1985de6c6

@k8s-ci-robot k8s-ci-robot merged commit b0a9eeb into kubernetes-sigs:release-1.9 Nov 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants