Skip to content

🌱 Enable MS in-place rollout check in e2e test #12943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

🌱 Enable MS in-place rollout check in e2e test #12943

wants to merge 1 commit into from

Conversation

@sbueringer
Copy link
Member

@sbueringer sbueringer commented Nov 4, 2025

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #12755

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Nov 4, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 4, 2025
@sbueringer sbueringer mentioned this pull request Nov 4, 2025
Open
79 tasks
@sbueringer sbueringer added the area/e2e-testing Issues or PRs related to e2e testing label Nov 4, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Nov 4, 2025
@sbueringer
Copy link
Member Author

sbueringer commented Nov 4, 2025

/test pull-cluster-api-e2e-main-gke

fabriziopandini
fabriziopandini reviewed Nov 4, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2025

LGTM label has been added.

Git tree hash: ac27997ec9b59f40b5c4c491eaec568485632b6c

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2025
@sbueringer
Copy link
Member Author

sbueringer commented Nov 4, 2025

/hold

We'll need some fixes to the implementation first before this can work

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2025
@sbueringer sbueringer force-pushed the pr-test-e2e-in-place-e2e branch from 09f4570 to c8ea7e5 Compare November 4, 2025 17:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2025
@sbueringer sbueringer force-pushed the pr-test-e2e-in-place-e2e branch from c8ea7e5 to 9b839d6 Compare November 4, 2025 18:01
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2025
@sbueringer
Copy link
Member Author

sbueringer commented Nov 4, 2025

/test pull-cluster-api-e2e-main-gke

@sbueringer sbueringer force-pushed the pr-test-e2e-in-place-e2e branch from 9b839d6 to dd93c5f Compare November 6, 2025 15:54
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 6, 2025
@sbueringer
Copy link
Member Author

sbueringer commented Nov 6, 2025

/test pull-cluster-api-e2e-main-gke

@sbueringer sbueringer force-pushed the pr-test-e2e-in-place-e2e branch from dd93c5f to 8ff5f0e Compare November 6, 2025 15:57
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2025
@sbueringer
Copy link
Member Author

sbueringer commented Nov 6, 2025

Included a few additional minor fixes in this PR. Didn't want to create another 2 PRs for these.

@sbueringer sbueringer force-pushed the pr-test-e2e-in-place-e2e branch from 8ff5f0e to aa511ff Compare November 6, 2025 16:01
@sbueringer
Copy link
Member Author

sbueringer commented Nov 6, 2025

/test pull-cluster-api-e2e-main-gke

@sbueringer
Copy link
Member Author

sbueringer commented Nov 6, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2025
@sbueringer
Enable MS in-place rollout check in e2e test
16169e1 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer sbueringer force-pushed the pr-test-e2e-in-place-e2e branch from aa511ff to 16169e1 Compare November 6, 2025 16:10
@sbueringer
Copy link
Member Author

sbueringer commented Nov 6, 2025

/test pull-cluster-api-e2e-main-gke

@fabriziopandini
Copy link
Member

fabriziopandini commented Nov 6, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 6, 2025

LGTM label has been added.

Git tree hash: e51aa327c0fc770a100199815b551a16486f2e59

fabriziopandini
fabriziopandini reviewed Nov 6, 2025
View reviewed changes
internal/controllers/machinedeployment/machinedeployment_rollout_rollingupdate.go

// Check if the MachineSet can update in place; if not, move to the next MachineSet.
canUpdateMachineSetInPlaceFunc := func(_ *clusterv1.MachineSet) bool { return false }
canUpdateMachineSetInPlaceFunc := func(_ *clusterv1.MachineSet) bool { return true }
Copy link
Member

@fabriziopandini fabriziopandini Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct this is temporary to get some test signal, right?

Copy link
Member Author

@sbueringer sbueringer Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Member Author

@sbueringer sbueringer Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably won't work atm anyway. Let's see where we are after the CanUpdateMachineSet PR and if the RX is disabled cleanly enough for other test cases or if we want to introduce some additional handling

Copy link
Member Author

@sbueringer sbueringer Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will only enable in-place for the in-place e2e test

@sbueringer
Copy link
Member Author

sbueringer commented Nov 6, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 6, 2025

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-e2e-main-gke 16169e1 link true /test pull-cluster-api-e2e-main-gke

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member Author

sbueringer commented Nov 7, 2025

/close

Will be integrated into #12965

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 7, 2025

@sbueringer: Closed this PR.

In response to this:

/close

Will be integrated into #12965

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@elmiko elmiko Awaiting requested review from elmiko

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@fabriziopandini fabriziopandini

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbueringer @k8s-ci-robot @fabriziopandini