WIP: 🐛 Fix SG deletion logic on Default VPC

[mloiseleur]

What type of PR is this?

/kind bug

What this PR does / why we need it:

It removes an invalid event when enabling emptyRoutesDefaultVPCSecurityGroup on AWSManagedControlPlane like this:

apiVersion: controlplane.cluster.x-k8s.io/v1beta2
kind: AWSManagedControlPlane
metadata:
  name: test
spec:
  [...]
  network:
    vpc:
      emptyRoutesDefaultVPCSecurityGroup: true

Without this PR, it creates tons of events like this:

Checklist:

• squashed commits
• includes documentation
• includes emoji in title
• adds unit tests
• adds or updates e2e tests

Release note:

Fix SecurityGroup deletion logic on Default VPC

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dlipovetsky for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[AndiDog]

This special handling could lead to more bugs. For example, authorizeSecurityGroupIngressRules is still below and is also exempted with this continue statement.

Can we instead rather fix this by ignoring the NotFound error where it happens?

(We're also observing this annoying problem for non-EKS clusters, by the way.)

[AndiDog]

No difference here, or am I overlooking something?