-
Notifications
You must be signed in to change notification settings - Fork 95
doc: add type reminder for volumeAttributes.mountWithWorkloadIdentityToken
#2262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @JoeyC-Dev! |
|
Hi @JoeyC-Dev. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a type reminder to the documentation for the mountWithWorkloadIdentityToken parameter to prevent a common configuration error where users might use a boolean type instead of a string type in YAML configuration.
Key Changes:
- Added clarification text "(use the type "string" instead of "bool")" to the Available Value column for
volumeAttributes.mountWithWorkloadIdentityTokenparameter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andyzhangx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
andyzhangx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, JoeyC-Dev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Customer may use
boolinstead ofstringin yaml configuration and will cause the error below:Add a reminder will help.
This works:
This doesn't work:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: