Support whitespace in tag keys and values

[slackfan]

Is this a bug fix or adding new feature?

This PR adds a feature.

What is this PR about? / Why do we need it?

The current EFS Driver implementation does not support whitespace in tagging keys and values while the EFS API itself does support that.

The proposed implementation adds escaping support for the whitespace, allowing to configure the tags accordingly so the Driver implementation can handle it and causes fancy potentially undesirable tag values being written in case this is not known.

I chose to implement this via escape sequence. Namely a backslash as this was chosen recently via PR #1693

Existing behavior is mainly kept. The only difference I propose to implement is that empty tag values are supported. Before the changes this raised an error, after the changes a missing colon separator leads to an empty value.

What testing is done?

Additional unit tests have been added.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: slackfan / name: slackfan (780b9d6)

[k8s-ci-robot]

Welcome @slackfan!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @slackfan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[slackfan]

Also, for I chose not to modify The Helm charts helper function https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/charts/aws-efs-csi-driver/templates/_helpers.tpl#L50 As changing it would break existing behavior (existing workarounds in place). If it makes sense to add automatic escaping there, let me know.

[slackfan]

What would be needed to move this forward? If something is missing, please let me know.

[dankova22]

/ok-to-test

[dankova22]

Hi, could you please rebase your changes if you would like the feature to be supported?

[slackfan]

/retest

[slackfan]

@dankova22, thanks for the heads-up, the PR is updated and tests are green.

[DavidXU12345]

@slackfan Could you pleaes squash all the commits to a single one before we merge it? thanks

[slackfan]

@DavidXU12345, as requested, everything is in a single commit now.

[DavidXU12345]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidXU12345, samuhale, slackfan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [DavidXU12345]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment