Graceful termination for server #794
Open
+158
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ipochi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Signed-off-by: Imran Pochi <imranpochi@microsoft.com>
ipochi
force-pushed
the
imran/graceful-termination-for-server
branch
from
c14cffa to
dedeefa
Compare
k8s-ci-robot
added
size/L
Signed-off-by: Imran Pochi <imranpochi@microsoft.com>
cheftako
reviewed
Oct 31, 2025
cheftako
reviewed
Oct 31, 2025
cheftako
reviewed
Oct 31, 2025
Signed-off-by: Imran Pochi <imranpochi@microsoft.com>
if leaseController is enabled and graceful shutdown is enabled as well, without this lease controller will terminate while the servers would continue to shutdown gracefully. Potentially causing a situtaion where the leases will be deleted while the existing connections are still served upto shutdown point. Signed-off-by: Imran Pochi <imranpochi@microsoft.com>
Contributor
Author
|
@cheftako Please re-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the server doesn't do graceful termination upon receiving kill signals. This PR proposes the fix to add a configurable graceful termination to the server.