ENH: added WARNINGS_ARE_ERRORS=1 by default

[muschellij2]

Trying to harmonize with travis defaults: https://docs.travis-ci.com/user/languages/r/#package-check-options, alongside https://github.com/travis-ci/travis-build/blob/master/lib/travis/build/script/r.rb#L13, so that warnings are treated as errors by default.

This is potentially breaking behavior and also not "easy" for most users if they don't know how to set global variables or unset.

[krlmlr]

Thanks. This would need an update of the README too.

Do the logs contain an explanation what to do if builds fail? If yes, I think it would be safe to merge.

[muschellij2]

Yes, I may need to look around for an example, but every job, such as: https://ci.appveyor.com/project/muschellij2/text2speech will have the warnings as errors dump at the bottom and the artifacts should have it as well: https://ci.appveyor.com/project/muschellij2/text2speech/build/artifacts. I think to harmonize with https://github.com/travis-ci/travis-build/blob/master/lib/travis/build/script/r.rb#L13, it would be a good default. John

…

On Mon, Apr 22, 2019 at 5:28 PM Kirill Müller ***@***.***> wrote: Thanks. This would need an update of the README too. Do the logs contain an explanation what to do if builds fail? If yes, I think it would be safe to merge. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#146 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIGPLVE67COSJMKIPTMF6DPRYUZHANCNFSM4G62RVXA> .