Fix: Move DataTransfer permission to Automation group in ACL #2394
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference
User with DataTransfer permission unable to see DataTransfer option in Settings #2373
This PR fixes an issue where users with the DataTransfer permission could not see the option in the Settings menu.
The Problem: The data_transfer permission group was incorrectly placed in the acl.php configuration file, causing it to be hidden from the UI even when assigned.
The Fix: I have moved the data_transfer permission group under settings -> automation in packages/Webkul/Admin/src/Config/acl.php
How To Test This?
Steps to Reproduce (Verified)
Create a new role and assign it the "DataTransfer" permission.
Create a new user and assign this role to them.
Log in as the newly created user.
Navigate to Settings -> Automation.
The DataTransfer option is now visible under automation not as a standalone (which made the module not display on assignment).
Evidence
Before (Issue): https://webkul.chatwhizz.com/share/view-recording/68da82a87f05a00572f6d57f
After:
