Skip to content

Plugin: Kourier #6456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Plugin: Kourier #6456

wants to merge 12 commits into from
+174 −1

Conversation

@iRaindrop
Copy link
Contributor

@iRaindrop iRaindrop commented Oct 17, 2025 •
edited
Loading

Need topic to install the Kourier plugin. Source: https://github.com/knative-extensions/net-kourier

Proposed Changes

  • Create Installing Kourier to include in the Plugin section for Installing Knative.

@knative-prow knative-prow bot requested review from dsimansk and pierDipi October 17, 2025 06:54
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 17, 2025
@iRaindrop iRaindrop marked this pull request as draft October 17, 2025 06:55
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2025
@netlify
Copy link

netlify bot commented Oct 17, 2025 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e9ea30c
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/69196f770b5a270008f2ed42
😎 Deploy Preview https://deploy-preview-6456--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@iRaindrop iRaindrop changed the title Add Installing-Kourier to Knative installation documentation Add Installing Kourier to Knative installation documentation Oct 17, 2025
@iRaindrop iRaindrop changed the title Add Installing Kourier to Knative installation documentation Add Installing Kourier to docs Oct 17, 2025
@iRaindrop iRaindrop marked this pull request as ready for review October 20, 2025 07:20
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2025
dprotaso
dprotaso reviewed Oct 20, 2025
View reviewed changes
Copy link
Member

@dprotaso dprotaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious - we cover this stuff here already given it's related to serving - are these pages meant to be duplicated or are we cleaning out the sections?

https://knative.dev/docs/install/yaml-install/serving/install-serving-with-yaml/#install-a-networking-layer

evankanderson
evankanderson reviewed Oct 21, 2025
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for collecting this documentation! A few comments, but it's nice to have the documentation gathered in one place.

It looks like most of the configuration information was surfaced from outside the existing docs tree, so thanks for digging that up!

@evankanderson
Copy link
Member

evankanderson commented Oct 21, 2025

/assign

@dprotaso
Copy link
Member

dprotaso commented Oct 21, 2025

/assign @dsimansk

As the resident Kourier expert

@iRaindrop iRaindrop marked this pull request as draft October 24, 2025 18:52
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2025
@iRaindrop iRaindrop changed the title Add Installing Kourier to docs Plugin: Kourier Oct 25, 2025
@iRaindrop
Copy link
Contributor Author

iRaindrop commented Oct 25, 2025

This content will now be under Configuring Knative->Networking Options->Plugin: Kourier

@iRaindrop @evankanderson
Update docs/versioned/install/installing-kourier.md
b363d57 
Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
@knative-prow
Copy link

knative-prow bot commented Nov 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iRaindrop
Once this PR has been reviewed and has the lgtm label, please ask for approval from dsimansk. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

iRaindrop and others added 3 commits November 13, 2025 22:51
@evankanderson
Copy link
Member

evankanderson commented Nov 15, 2025

Are you ready for another review, or do you have more work you want to complete first?

@iRaindrop
Copy link
Contributor Author

iRaindrop commented Nov 15, 2025

Are you ready for another review, or do you have more work you want to complete first?

More to do, all 3 should be ready Monday

@iRaindrop
General edits
d1f0578 
also Nav title tweak
@iRaindrop
Update installing-kourier.md
9635597 
Misc edits and formatting
@iRaindrop
Update installing-kourier.md
14a93d3 
Casing in heading titles fixes
@iRaindrop
Title tweak and edits
e9ea30c 
Refinement edits
@iRaindrop iRaindrop marked this pull request as ready for review November 16, 2025 06:35
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2025
@knative-prow knative-prow bot requested review from Leo6Leo and dprotaso November 16, 2025 06:35
@iRaindrop
Copy link
Contributor Author

iRaindrop commented Nov 16, 2025

Ready for PR approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson evankanderson left review comments

@dsimansk dsimansk Awaiting requested review from dsimansk

@pierDipi pierDipi Awaiting requested review from pierDipi

@zainabhusain227 zainabhusain227 Awaiting requested review from zainabhusain227

@dprotaso dprotaso Awaiting requested review from dprotaso

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@dsimansk dsimansk

@evankanderson evankanderson

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iRaindrop @evankanderson @dprotaso @dsimansk