Merge branch 'develop' into copilot/create-notification-channel

Author: sds100

CHANGELOG.md

@@ -1,3 +1,24 @@
+## [4.0.0 Beta 3](https://github.com/sds100/KeyMapper/releases/tag/v4.0.0-beta.03)
+
+#### TO BE RELEASED
+
+## Added
+- #1871 action to modify any system settings
+
+## [4.0.0 Beta 2](https://github.com/sds100/KeyMapper/releases/tag/v4.0.0-beta.02)
+
+#### 08 November 2025
+
+## Added
+
+- #1890 add button to save log to file and share it. The clipboard button now cuts off older entries and keeps newest ones.
+
+## Fixed
+
+- Only autostart PRO mode with Shizuku if Shizuku permission is granted. Otherwise fallback to method with Wireless Debugging and WRITE_SECURE_SETTINGS permission.
+- Starting system bridge for the first time would be janky because granting READ_LOGS kills the app process. Only grant for READ_LOGS when sharing logcat from settings.
+- #1886 mobile data actions work in PRO mode.
+
 ## [4.0.0 Beta 1](https://github.com/sds100/KeyMapper/releases/tag/v4.0.0-beta.01)
 
 #### 01 November 2025

app/proguard-rules.pro

@@ -75,6 +75,8 @@
 -keep class io.github.sds100.keymapper.api.IKeyEventRelayService$Stub { *; }
 -keep class io.github.sds100.keymapper.api.IKeyEventRelayServiceCallback { *; }
 -keep class io.github.sds100.keymapper.api.IKeyEventRelayServiceCallback$Stub { *; }
+-keep class com.android.internal.telephony.ITelephony { *; }
+-keep class com.android.internal.telephony.ITelephony$Stub { *; }
 
 -keepattributes *Annotation*, InnerClasses
 -dontnote kotlinx.serialization.AnnotationsKt # core serialization annotations

app/version.properties

@@ -1,3 +1,3 @@
-VERSION_NAME=4.0.0-beta.2
-VERSION_CODE=186
+VERSION_NAME=4.0.0-beta.3
+VERSION_CODE=189
 VERSION_NUM=01

base/src/main/assets/whats-new.txt

@@ -1,11 +1,12 @@
 ✨ Screen-off remapping
-You can now remap buttons when the screen is off (including the power button) for free with PRO mode.
+You can now remap ALL buttons when the screen is off (including the power button) for free with PRO mode.
 
 🎯 New Actions
 • Run shell commands
 • Send SMS messages
 • Force stop current app or clear from recents
 • Mute/unmute microphone
+• Modify any system setting
 
 🆕 New Features
 • Redesigned Settings screen

base/src/main/java/io/github/sds100/keymapper/base/BaseKeyMapperApp.kt

@@ -29,6 +29,7 @@ import io.github.sds100.keymapper.data.repositories.LogRepository
 import io.github.sds100.keymapper.data.repositories.PreferenceRepositoryImpl
 import io.github.sds100.keymapper.sysbridge.manager.SystemBridgeConnectionManagerImpl
 import io.github.sds100.keymapper.sysbridge.manager.SystemBridgeConnectionState
+import io.github.sds100.keymapper.sysbridge.manager.isConnected
 import io.github.sds100.keymapper.system.apps.AndroidPackageManagerAdapter
 import io.github.sds100.keymapper.system.devices.AndroidDevicesAdapter
 import io.github.sds100.keymapper.system.inputmethod.KeyEventRelayServiceWrapperImpl
@@ -224,6 +225,12 @@ abstract class BaseKeyMapperApp : MultiDexApplication() {
         autoGrantPermissionController.start()
         keyEventRelayServiceWrapper.bind()
 
+        if (systemBridgeConnectionManager.isConnected()) {
+            Timber.i("KeyMapperApp: System bridge is connected")
+        } else {
+            Timber.i("KeyMapperApp: System bridge is disconnected")
+        }
+
         if (Build.VERSION.SDK_INT >= Constants.SYSTEM_BRIDGE_MIN_API) {
             systemBridgeAutoStarter.init()
 

base/src/main/java/io/github/sds100/keymapper/base/BaseMainActivity.kt

@@ -21,7 +21,6 @@ import androidx.lifecycle.Lifecycle
 import androidx.lifecycle.flowWithLifecycle
 import androidx.lifecycle.lifecycleScope
 import androidx.lifecycle.withStateAtLeast
-import androidx.navigation.findNavController
 import com.anggrayudi.storage.extension.openInputStream
 import com.anggrayudi.storage.extension.openOutputStream
 import com.anggrayudi.storage.extension.toDocumentFile
@@ -32,6 +31,7 @@ import io.github.sds100.keymapper.base.onboarding.OnboardingUseCase
 import io.github.sds100.keymapper.base.system.accessibility.AccessibilityServiceAdapterImpl
 import io.github.sds100.keymapper.base.system.permissions.RequestPermissionDelegate
 import io.github.sds100.keymapper.base.trigger.RecordTriggerControllerImpl
+import io.github.sds100.keymapper.base.utils.navigation.NavigationProvider
 import io.github.sds100.keymapper.base.utils.ui.ResourceProviderImpl
 import io.github.sds100.keymapper.common.BuildConfigProvider
 import io.github.sds100.keymapper.sysbridge.service.SystemBridgeSetupControllerImpl
@@ -105,6 +105,9 @@ abstract class BaseMainActivity : AppCompatActivity() {
     @Inject
     lateinit var inputEventHub: InputEventHubImpl
 
+    @Inject
+    lateinit var navigationProvider: NavigationProvider
+
     private lateinit var requestPermissionDelegate: RequestPermissionDelegate
 
     private val currentNightMode: Int
@@ -162,15 +165,14 @@ abstract class BaseMainActivity : AppCompatActivity() {
             notificationReceiverAdapter = notificationReceiverAdapter,
             buildConfigProvider = buildConfigProvider,
             shizukuAdapter = shizukuAdapter,
+            navigationProvider = navigationProvider,
+            coroutineScope = lifecycleScope,
         )
 
         permissionAdapter.request
             .flowWithLifecycle(lifecycle, Lifecycle.State.STARTED)
             .onEach { permission ->
-                requestPermissionDelegate.requestPermission(
-                    permission,
-                    findNavController(R.id.container),
-                )
+                requestPermissionDelegate.requestPermission(permission)
             }
             .launchIn(lifecycleScope)
 
@@ -201,9 +203,10 @@ abstract class BaseMainActivity : AppCompatActivity() {
         // the activities have not necessarily resumed at that point.
         permissionAdapter.onPermissionsChanged()
         serviceAdapter.invalidateState()
-        suAdapter.invalidateIsRooted()
+        suAdapter.requestPermission()
         systemBridgeSetupController.invalidateSettings()
         networkAdapter.invalidateState()
+        onboardingUseCase.handledMigrateScreenOffKeyMapsNotification()
     }
 
     override fun onDestroy() {

base/src/main/java/io/github/sds100/keymapper/base/BaseMainNavHost.kt

@@ -18,6 +18,7 @@ import androidx.navigation.compose.NavHost
 import androidx.navigation.compose.composable
 import io.github.sds100.keymapper.base.actions.ChooseActionScreen
 import io.github.sds100.keymapper.base.actions.ChooseActionViewModel
+import io.github.sds100.keymapper.base.actions.ChooseSettingScreen
 import io.github.sds100.keymapper.base.actions.ConfigCreateNotificationViewModel
 import io.github.sds100.keymapper.base.actions.ConfigShellCommandViewModel
 import io.github.sds100.keymapper.base.actions.CreateNotificationActionScreen
@@ -179,6 +180,13 @@ fun BaseMainNavHost(
             )
         }
 
+        composable<NavDestination.ChooseSetting> {
+            ChooseSettingScreen(
+                modifier = Modifier.fillMaxSize(),
+                viewModel = hiltViewModel(),
+            )
+        }
+
         composableDestinations()
     }
 }

base/src/main/java/io/github/sds100/keymapper/base/actions/ActionData.kt

@@ -963,4 +963,24 @@ sealed class ActionData : Comparable<ActionData> {
     data object ClearRecentApp : ActionData() {
         override val id: ActionId = ActionId.CLEAR_RECENT_APP
     }
+
+    @Serializable
+    data class ModifySetting(
+        val settingType: io.github.sds100.keymapper.system.settings.SettingType,
+        val settingKey: String,
+        val value: String,
+    ) : ActionData() {
+        override val id: ActionId = ActionId.MODIFY_SETTING
+
+        override fun compareTo(other: ActionData) = when (other) {
+            is ModifySetting -> compareValuesBy(
+                this,
+                other,
+                { it.settingType },
+                { it.settingKey },
+                { it.value },
+            )
+            else -> super.compareTo(other)
+        }
+    }
 }

base/src/main/java/io/github/sds100/keymapper/base/actions/ActionDataEntityMapper.kt

@@ -22,6 +22,7 @@ import io.github.sds100.keymapper.system.camera.CameraLens
 import io.github.sds100.keymapper.system.intents.IntentExtraModel
 import io.github.sds100.keymapper.system.intents.IntentTarget
 import io.github.sds100.keymapper.system.network.HttpMethod
+import io.github.sds100.keymapper.system.settings.SettingType
 import io.github.sds100.keymapper.system.volume.DndMode
 import io.github.sds100.keymapper.system.volume.RingerMode
 import io.github.sds100.keymapper.system.volume.VolumeStream
@@ -50,6 +51,7 @@ object ActionDataEntityMapper {
 
             ActionEntity.Type.INTERACT_UI_ELEMENT -> ActionId.INTERACT_UI_ELEMENT
             ActionEntity.Type.SHELL_COMMAND -> ActionId.SHELL_COMMAND
+            ActionEntity.Type.MODIFY_SETTING -> ActionId.MODIFY_SETTING
             ActionEntity.Type.CREATE_NOTIFICATION -> ActionId.CREATE_NOTIFICATION
         }
 
@@ -740,6 +742,26 @@ object ActionDataEntityMapper {
 
             ActionId.FORCE_STOP_APP -> ActionData.ForceStopApp
             ActionId.CLEAR_RECENT_APP -> ActionData.ClearRecentApp
+
+            ActionId.MODIFY_SETTING -> {
+                val value = entity.extras.getData(ActionEntity.EXTRA_SETTING_VALUE)
+                    .valueOrNull() ?: return null
+
+                val settingTypeString = entity.extras.getData(ActionEntity.EXTRA_SETTING_TYPE)
+                    .valueOrNull() ?: "SYSTEM" // Default to SYSTEM for backward compatibility
+
+                val settingType = try {
+                    SettingType.valueOf(settingTypeString)
+                } catch (_: IllegalArgumentException) {
+                    SettingType.SYSTEM
+                }
+
+                ActionData.ModifySetting(
+                    settingType = settingType,
+                    settingKey = entity.data,
+                    value = value,
+                )
+            }
         }
     }
 
@@ -766,6 +788,7 @@ object ActionDataEntityMapper {
             is ActionData.Sound -> ActionEntity.Type.SOUND
             is ActionData.InteractUiElement -> ActionEntity.Type.INTERACT_UI_ELEMENT
             is ActionData.ShellCommand -> ActionEntity.Type.SHELL_COMMAND
+            is ActionData.ModifySetting -> ActionEntity.Type.MODIFY_SETTING
             is ActionData.CreateNotification -> ActionEntity.Type.CREATE_NOTIFICATION
             else -> ActionEntity.Type.SYSTEM_ACTION
         }
@@ -844,6 +867,7 @@ object ActionDataEntityMapper {
         is ActionData.ControlMedia.Rewind -> SYSTEM_ACTION_ID_MAP[data.id]!!
         is ActionData.ControlMedia.Stop -> SYSTEM_ACTION_ID_MAP[data.id]!!
         is ActionData.GoBack -> SYSTEM_ACTION_ID_MAP[data.id]!!
+        is ActionData.ModifySetting -> data.settingKey
         else -> SYSTEM_ACTION_ID_MAP[data.id]!!
     }
 
@@ -1124,6 +1148,11 @@ object ActionDataEntityMapper {
             EntityExtra(ActionEntity.EXTRA_SHELL_COMMAND_TIMEOUT, data.timeoutMillis.toString()),
         )
 
+        is ActionData.ModifySetting -> listOf(
+            EntityExtra(ActionEntity.EXTRA_SETTING_VALUE, data.value),
+            EntityExtra(ActionEntity.EXTRA_SETTING_TYPE, data.settingType.name),
+        )
+
         is ActionData.CreateNotification -> buildList {
             add(EntityExtra(ActionEntity.EXTRA_NOTIFICATION_TITLE, data.title))
             data.timeoutMs?.let { 
@@ -1305,5 +1334,7 @@ object ActionDataEntityMapper {
         ActionId.HTTP_REQUEST to "http_request",
         ActionId.FORCE_STOP_APP to "force_stop_app",
         ActionId.CLEAR_RECENT_APP to "clear_recent_app",
+
+        ActionId.MODIFY_SETTING to "modify_setting",
     )
 }

base/src/main/java/io/github/sds100/keymapper/base/actions/ActionErrorSnapshot.kt

@@ -27,6 +27,7 @@ import io.github.sds100.keymapper.system.permissions.Permission
 import io.github.sds100.keymapper.system.permissions.PermissionAdapter
 import io.github.sds100.keymapper.system.permissions.SystemFeatureAdapter
 import io.github.sds100.keymapper.system.ringtones.RingtoneAdapter
+import io.github.sds100.keymapper.system.settings.SettingType
 
 class LazyActionErrorSnapshot(
     private val packageManager: PackageManagerAdapter,
@@ -231,6 +232,27 @@ class LazyActionErrorSnapshot(
                 }
             }
 
+            is ActionData.ModifySetting -> {
+                return when (action.settingType) {
+                    SettingType.SYSTEM -> {
+                        if (!isPermissionGranted(Permission.WRITE_SETTINGS)) {
+                            SystemError.PermissionDenied(Permission.WRITE_SETTINGS)
+                        } else {
+                            null
+                        }
+                    }
+                    SettingType.SECURE,
+                    SettingType.GLOBAL,
+                        -> {
+                        if (!isPermissionGranted(Permission.WRITE_SECURE_SETTINGS)) {
+                            SystemError.PermissionDenied(Permission.WRITE_SECURE_SETTINGS)
+                        } else {
+                            null
+                        }
+                    }
+                }
+            }
+
             else -> {}
         }