Address PR review feedback

- Use action.hashCode() for notification ID as requested
- Rename ConfigCreateNotification to ConfigNotificationAction

Co-authored-by: sds100 <16245954+sds100@users.noreply.github.com>

Author: Copilot

base/src/main/java/io/github/sds100/keymapper/base/BaseMainNavHost.kt

@@ -91,10 +91,10 @@ fun BaseMainNavHost(
             )
         }
 
-        composable<NavDestination.ConfigCreateNotification> { backStackEntry ->
+        composable<NavDestination.ConfigNotificationAction> { backStackEntry ->
             val viewModel: ConfigCreateNotificationViewModel = hiltViewModel()
 
-            backStackEntry.handleRouteArgs<NavDestination.ConfigCreateNotification> { destination ->
+            backStackEntry.handleRouteArgs<NavDestination.ConfigNotificationAction> { destination ->
                 destination.actionJson?.let { viewModel.loadAction(Json.decodeFromString(it)) }
             }
 

base/src/main/java/io/github/sds100/keymapper/base/actions/CreateActionDelegate.kt

@@ -889,7 +889,7 @@ class CreateActionDelegate(
 
                 return navigate(
                     "config_create_notification_action",
-                    NavDestination.ConfigCreateNotification(
+                    NavDestination.ConfigNotificationAction(
                         oldAction?.let {
                             Json.encodeToString(oldAction)
                         },

base/src/main/java/io/github/sds100/keymapper/base/actions/PerformActionsUseCase.kt

@@ -932,11 +932,8 @@ class PerformActionsUseCaseImpl @AssistedInject constructor(
             }
 
             is ActionData.CreateNotification -> {
-                // Generate a unique notification ID using absolute value to avoid negative IDs
-                // Combine timestamp and hash to ensure uniqueness
-                val timestamp = (System.currentTimeMillis() / 1000).toInt()
-                val contentHash = (action.title + action.text).hashCode()
-                val notificationId = (timestamp.toLong() + contentHash).toInt().let { 
+                // Use the hashcode of the action instance as the unique notification ID
+                val notificationId = action.hashCode().let { 
                     if (it < 0) -it else it 
                 }
 

base/src/main/java/io/github/sds100/keymapper/base/utils/navigation/NavDestination.kt

@@ -174,7 +174,7 @@ abstract class NavDestination<R>(val isCompose: Boolean = false) {
     }
 
     @Serializable
-    data class ConfigCreateNotification(val actionJson: String?) :
+    data class ConfigNotificationAction(val actionJson: String?) :
         NavDestination<ActionData.CreateNotification>(isCompose = true) {
         override val id: String = ID_CREATE_NOTIFICATION_ACTION
     }