Skip to content

Add dora support #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add dora support #2371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3b972e9
Add DoRA dense layer and embeddings layer with BERT integration
Ajinkya-25 Aug 26, 2025
cf639d9
Update API stubs
Ajinkya-25 Aug 26, 2025
6c9e097
Merge remote-tracking branch 'upstream/master' into add-dora-support
Ajinkya-25 Aug 27, 2025
d64bc3b
added support to various backend in dora
Ajinkya-25 Aug 27, 2025
10e18e9
added support t jax with api generation
Ajinkya-25 Aug 27, 2025
7c92906
resolve position embedding issue
Ajinkya-25 Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions keras_hub/api/layers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,19 @@
from keras_hub.src.layers.modeling.cached_multi_head_attention import (
CachedMultiHeadAttention as CachedMultiHeadAttention,
)
from keras_hub.src.layers.modeling.dora_dense import DoRADense as DoRADense
from keras_hub.src.layers.modeling.dora_dense import (
convert_dense_to_dora as convert_dense_to_dora,
)
from keras_hub.src.layers.modeling.dora_embeddings import (
DoRAEmbedding as DoRAEmbedding,
)
from keras_hub.src.layers.modeling.dora_embeddings import (
DoRAPositionEmbedding as DoRAPositionEmbedding,
)
from keras_hub.src.layers.modeling.dora_embeddings import (
convert_embedding_to_dora as embedding_to_dora,
)
Comment on lines +25 to +27
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with convert_dense_to_dora, it would be better to alias convert_embedding_to_dora to convert_embedding_to_dora instead of embedding_to_dora. This makes the public API more predictable and consistent.

Suggested change
from keras_hub.src.layers.modeling.dora_embeddings import (
convert_embedding_to_dora as embedding_to_dora,
)
from keras_hub.src.layers.modeling.dora_embeddings import (
convert_embedding_to_dora as convert_embedding_to_dora,
)

from keras_hub.src.layers.modeling.f_net_encoder import (
FNetEncoder as FNetEncoder,
)
Expand Down
Loading
Loading