Skip to content

Conversation

@simonmcl
Copy link
Collaborator

Addresses: #212

  • Added another parameter to TezosClient and NetworkClient to take a remoteNodeParseURL so that a second server can be used to verify the forged transactions.
  • Changed forgeSignPreapplyAndInject to forgeParseSignPreapplyAndInject and added a parse flow.
  • The returned JSON from the parse will be compared to the operations requested to be sent.
  • Operation will fail if the comparison fails.
  • Change Tez.rpcRepresentation to always return a minimum of "0", as the Node will always replace "" with "0".

…s an extra layer of security

- changed Tez rpc representation to return "0" at a minimum to avoid conflicts with the node
@simonmcl simonmcl added enhancement New feature or request security labels Jun 30, 2020
@simonmcl simonmcl requested a review from keefertaylor June 30, 2020 15:12
@simonmcl simonmcl self-assigned this Jun 30, 2020
simonmcl added 13 commits July 2, 2020 12:48
…due to multiple different types of responses
BugFix: conseil `orderBy` not using correct format of array of dictionaries
… for Dexter contracts. OperationResponse is not catching these responses first, as /preapply returns an array, were as all others return a dictionary. Adding a quick hack to detect this difference and parse the errors correctly.
…ething with errors inaccessible, such as estimation errors

- hack: make everything public on TezosNodeClient so settings can be accessed and modified by app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants