Rewrite Location header in redirect responses. #544
+179
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserve the proxy prefix in the path info when the proxied server sends the client to a location without a scheme or host.
for more information, see https://pre-commit.ci
manics
reviewed
Nov 3, 2025
jupyter_server_proxy/handlers.py
Outdated
| self._headers = httputil.HTTPHeaders() | ||
| for header, v in rewritten_response.headers.get_all(): | ||
| if header not in ("Content-Length", "Transfer-Encoding", "Connection"): | ||
| # Rewrite Location header in redirects to preserve proxy prefix |
Member
There was a problem hiding this comment.
I think this should only be rewritten if absolute_url == False:
https://jupyter-server-proxy.readthedocs.io/en/stable/server-process.html#absolute-url
Collaborator
Author
There was a problem hiding this comment.
Fixed! Thanks for catching that.
…er-server-proxy into rewrite_location_header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve the proxy prefix in the path info when the proxied server sends the client to a location without a scheme or host.