Skip to content

allow configuring client_class and client_factory #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2025
Merged

allow configuring client_class and client_factory #1081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions jupyter_client/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,9 @@ def _context_default(self) -> zmq.Context:

# the class to create with our `client` method
client_class: DottedObjectName = DottedObjectName(
"jupyter_client.blocking.BlockingKernelClient"
"jupyter_client.blocking.BlockingKernelClient", config=True
)
client_factory: Type = Type(klass=KernelClient)
client_factory: Type = Type(klass=KernelClient, config=True)

@default("client_factory")
def _client_factory_default(self) -> Type:
Expand Down Expand Up @@ -716,9 +716,9 @@ class AsyncKernelManager(KernelManager):

# the class to create with our `client` method
client_class: DottedObjectName = DottedObjectName(
"jupyter_client.asynchronous.AsyncKernelClient"
"jupyter_client.asynchronous.AsyncKernelClient", config=True
)
client_factory: Type = Type(klass="jupyter_client.asynchronous.AsyncKernelClient")
client_factory: Type = Type(klass="jupyter_client.asynchronous.AsyncKernelClient", config=True)

# The PyZMQ Context to use for communication with the kernel.
context: Instance = Instance(zmq.asyncio.Context)
Expand Down