Skip to content

Various enhancements in OpenAPI support #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 29, 2024
Merged

Various enhancements in OpenAPI support #1648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
22f6d92
Various small internal cleanups
bkoelman Nov 27, 2024
b38f195
Fixed: do not emit AdditionalProperties on relationshipName and resou…
bkoelman Nov 27, 2024
a0aec70
Rename operationDiscriminator to openapi:discriminator and emit as pr…
bkoelman Nov 28, 2024
e193759
Add missing meta in resource identifier objects, add missing meta in …
bkoelman Nov 28, 2024
ddb5e10
Add missing request meta in top-level documents and relationship objects
bkoelman Nov 28, 2024
8bab51a
Change discriminator type in dataInResponse from string to ResourceTy…
bkoelman Nov 28, 2024
732e52c
Simplify assertions
bkoelman Nov 28, 2024
5454188
Rename ResourceTypeInfo to ResourceSchemaType
bkoelman Nov 29, 2024
d10d51b
Reorder constructor parameters: IJsonApiOptions before IResourceGraph
bkoelman Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/usage/openapi-client.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,13 +220,13 @@ Our [example project](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/
which seems to work. If you're an MSBuild expert, please help out!

```xml
<Target Name="RemoveKiotaGeneratedCode" BeforeTargets="BeforeCompile;CoreCompile" Condition="$(DesignTimeBuild) != true And $(BuildingProject) == true">
<Target Name="ExcludeKiotaGeneratedCode" BeforeTargets="BeforeCompile;CoreCompile" Condition="$(DesignTimeBuild) != true And $(BuildingProject) == true">
<ItemGroup>
<Compile Remove="**\GeneratedCode\**\*.cs" />
</ItemGroup>
</Target>

<Target Name="KiotaRunTool" BeforeTargets="BeforeCompile;CoreCompile" AfterTargets="RemoveKiotaGeneratedCode"
<Target Name="KiotaRunTool" BeforeTargets="BeforeCompile;CoreCompile" AfterTargets="ExcludeKiotaGeneratedCode"
Condition="$(DesignTimeBuild) != true And $(BuildingProject) == true">
<Exec
Command="dotnet kiota generate --language CSharp --class-name ExampleApiClient --namespace-name OpenApiKiotaClientExample.GeneratedCode --output ./GeneratedCode --backing-store --exclude-backward-compatible --clean-output --clear-cache --log-level Error --openapi ../JsonApiDotNetCoreExample/GeneratedSwagger/JsonApiDotNetCoreExample.json" />
Expand Down
Loading
Loading