Skip to content

Conversation

@isakb
Copy link

@isakb isakb commented Mar 30, 2017

No description provided.

Copy link
Owner

@jsdevel jsdevel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the build failed. I'm somewhat tempted to have a new branch, something like beta, then we can push changes like this out to npm with a beta version.

@@ -1,6 +1,6 @@
{
"name": "webdriver-sync",
"version": "0.18.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll handle bumping when we publish. please revert this.

@isakb isakb changed the title Bump minor version, update dependencies Update dependencies Mar 31, 2017
@isakb
Copy link
Author

isakb commented Mar 31, 2017

@jsdevel thanks, I reverted the version number.

By the way, in case you are wondering why we needed to update the dependencies; the module fails to install in NodeJS 6.10.0 LTS when the old versions of the dependencies are used. I would suggest updating the travis config to test later versions of NodeJS as well.

@jsdevel
Copy link
Owner

jsdevel commented Mar 31, 2017

Can you add the latest version to the travis config? If the tests pass with the latest version of node, we may need to get creative with versioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants