Skip to content

resolve #197 add nordic character support for titleCase #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

resolve #197 add nordic character support for titleCase #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/string.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ string.js - Copyright (C) 2012-2014, JP Richardson <jprichardson@gmail.com>
titleCase: function() {
var s = this.s;
if (s) {
s = s.replace(/(^[a-z]| [a-z]|-[a-z]|_[a-z])/g,
s = s.replace(/(^[a-zæøåäö]| [a-zæøåäö]|-[a-zæøåäö]|_[a-zæøåäö])/g,
function($1){
return $1.toUpperCase();
}
Expand Down
7 changes: 7 additions & 0 deletions test/string.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,6 +744,13 @@
EQ (S(null).titleCase().s,null)
EQ (S(undefined).titleCase().s,undefined)
})
it('TitleCases nordics characters', function () {
EQ (S('ämpäri is a finnish word').titleCase().s, 'Ämpäri Is A Finnish Word')
EQ (S('Öljy is finnish and means oil').titleCase().s, 'Öljy Is Finnish And Means Oil')
EQ (S('åland is a place').titleCase().s, 'Åland Is A Place')
EQ (S('ødele sounds like norwegian').titleCase().s, 'Ødele Sounds Like Norwegian')
EQ (S('ærlandaa may be norwegian or danish, dunno').titleCase().s, 'Ærlandaa May Be Norwegian Or Danish, Dunno')
})
})

describe('- toFloat([precision])', function() {
Expand Down