Remove Change: footer on split push

[christian-schilling]

Some projects don't like extra metadata in the commit messages, and after the push it is not needed anyway.

[Copilot]

Pull Request Overview

This PR removes "Change:" footers from commit messages during split push operations to accommodate projects that don't want extra metadata. After pushing, the Change: footer is no longer needed in the remote repository.

Key Changes:

• Added regex-based text transformation functionality to remove "Change:" footers from commit messages
• Modified the unapply_filter function in history.rs to strip "Change:" footers when processing commits with change IDs
• Updated test expectations to reflect that "Change:" footers are removed after push

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
josh-core/src/filter/text.rs	New module providing template-based text transformation with regex support
josh-core/src/history.rs	Modified to apply text transformation to remove "Change:" footers during unapply operations
tests/cli/push_stacked_split.t	Updated test expectations to verify "Change:" footers are removed and commit hashes reflect the change

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The function contains complex template formatting logic (lines 18-50) that is not used in the current implementation. The only caller passes an empty string as the template, making the strfmt logic, string_storage, vars HashMap, and error handling for template formatting dead code. Consider simplifying to a basic regex replace function or documenting the intended future use of template parameters.

Suggested change

	// Build a HashMap with all named captures and globals
	// We need to store the string values to keep them alive for the HashMap references
	let mut string_storage: HashMap<String, String> = HashMap::new();
	// Collect all named capture values
	for name in re.capture_names().flatten() {
	if let Some(m) = caps.name(name) {
	string_storage.insert(name.to_string(), m.as_str().to_string());
	}
	}
	// Build the HashMap for strfmt with references to the stored strings
	let mut vars: HashMap<String, &dyn strfmt::DisplayStr> = HashMap::new();
	// Add all globals first (lower priority)
	for (key, value) in globals {
	vars.insert(key.clone(), value as &dyn strfmt::DisplayStr);
	}
	// Add all named captures (higher priority - will overwrite globals if there's a conflict)
	for (key, value) in &string_storage {
	vars.insert(key.clone(), value as &dyn strfmt::DisplayStr);
	}
	// Format the template, propagating errors
	match strfmt::strfmt(template, &vars) {
	Ok(s) => s,
	Err(e) => {
	let mut error = first_error.borrow_mut();
	if error.is_none() {
	*error = Some(e.into());
	}
	caps[0].to_string()
	}
	}
	})
	.into_owned();
	match first_error.into_inner() {
	Some(e) => Err(e),
	None => Ok(result),
	}
	// Since template formatting is not used, just return the matched string
	caps[0].to_string()
	})
	.into_owned();
	Ok(result)

[Copilot]

The regex pattern &\"(?m)^Change: [^ ]+\" has an unnecessary reference operator before the string literal. It should be \"(?m)^Change: [^ ]+\" (without the leading &). The Regex::new() function expects &str, not &&str.

[Copilot]

The regex pattern (?m)^Change: [^ ]+ will match and remove the line but leave the newline character, resulting in blank lines in commit messages. Consider using (?m)^Change: [^ ]+\\n? to also remove the trailing newline, or (?m)^Change: [^ ]+$\\n? to be more precise about matching end-of-line.