Skip changes without id in stacked push #1584
Open
+37
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR changes the behavior of stacked push operations to skip commits without a Change-Id instead of rejecting the entire push with an error. When pushing to refs/stack/for/* or refs/for/*, commits without Change-Ids are now silently filtered out rather than causing a 500 Internal Server Error.
- Removed error handling that rejected pushes containing commits without Change-Ids
- Updated test expectations to reflect successful pushes (200 OK instead of 500 errors)
- Commits without Change-Ids are now pushed to @heads namespace but skipped for @changes namespace
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| josh-core/src/changes.rs | Removed the else branch that returned an error when a change has no id, allowing such changes to be filtered out instead |
| tests/proxy/push_stacked.t | Updated test expectations to show successful push operations and correct ref updates for commits without Change-Ids |
| tests/proxy/push_stacked_gerrit.t | Updated test expectations for Gerrit-style pushes to reflect the new skip behavior |
| tests/proxy/push_stacked_sub.t | Updated test expectations for subdirectory pushes to show successful operations and additional git objects created |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
christian-schilling
force-pushed
the
@changes/master/christian.schilling.de@gmail.com/stacked-skip
branch
7 times, most recently
from
b9d666b to
f0bec0b
Compare
Instead of rejecting the whole push
christian-schilling
force-pushed
the
@changes/master/christian.schilling.de@gmail.com/stacked-skip
branch
from
f0bec0b to
ef1b9ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of rejecting the whole push