Skip to content

Address code review comments from PR #1518 #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2025
Merged

Address code review comments from PR #1518 #1582

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb2aa0b
Address code review comments from PR #1518
github-actions[bot] Nov 11, 2025
834452b
Address review feedback: simplify changes.rs code
github-actions[bot] Nov 12, 2025
cb9f3f9
Fix formatting: break long line in changes.rs
github-actions[bot] Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ opt-level = 3
codegen-units = 1

[workspace.dependencies]
anyhow = "1.0"
base64 = "0.22.1"
defer = "0.2.1"
env_logger = "0.11.5"
Expand Down
1 change: 1 addition & 0 deletions josh-cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ version = "22.4.15"
josh = { path = "../josh-core" }
josh-graphql = { path = "../josh-graphql" }
josh-templates = { path = "../josh-templates" }
anyhow = { workspace = true }
env_logger = { workspace = true }
log = { workspace = true }
serde_json = { workspace = true }
Expand Down
Loading