Skip to content

Conversation

@dwnusbaum
Copy link
Member

@dwnusbaum dwnusbaum commented Mar 28, 2025

See #83 (comment). Alternative to #388.

Testing done

Existing tests here pass for me locally, but if we want to go through with this we need to run it through the PCT.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@dwnusbaum dwnusbaum changed the title Delete GCFlushedOutputStream Delete GCFlushedOutputStream Mar 28, 2025
@jglick
Copy link
Member

jglick commented Apr 8, 2025

Prefer #388 but I only have a dim memory of what this was (supposed to be) solving. Perhaps remote TaskListeners which never get flushed before the callable exits?

@dwnusbaum
Copy link
Member Author

#388 now has a test that requires GCFlushedOutputStream, so we can at least verify that it works as intended under specialized conditions. I'm closing this in favor of that PR for now. However, if that PR turns out to cause any problems, then we should just delete the whole class instead.

@dwnusbaum dwnusbaum closed this Jul 7, 2025
@dwnusbaum dwnusbaum deleted the delete-GCFlushedOutputStream branch July 7, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants