Stop assigning random SCMSource.ids
#357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nclude something that does not vary
dwnusbaum
approved these changes
Nov 18, 2025
Member
Author
|
I will plan to merge this tomorrow, to make sure I have time to get jenkinsci/branch-api-plugin#567 released as well, since I do not think it is safe for people to update to just this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires jenkinsci/branch-api-plugin#567 to avoid regressions in multibranch project event dleivery.
compare #19, #37, #41
The design of Jenkins configuration, particularly when configuration-as-code is involved, expects persisted fields to have predictable values. Generating a random value for a field in some nested object to identify it in the future is not reliable. (The most recent example was anomalous behavior in a CloudBees CI HA controller, but there have historically been other problems.) Better would be to actually delete the
idfield and find a different system for dispatching webhook events and other uses, but this looked like a much bigger change that would be difficult to make compatible from both a code and saved settings perspective.