Skip to content

[Mosaic TPU] Remove pre-canonicalization optimization pass from tpu.td #33437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Nov 24, 2025
Merged

[Mosaic TPU] Remove pre-canonicalization optimization pass from tpu.td #33437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions jaxlib/mosaic/dialect/tpu/tpu.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1479,7 +1479,6 @@ def TPU_LogBufferOp : TPU_Op<"log_buffer"> {
}



def LogicalToPhysicalDeviceIdPass : Pass<"logical-to-physical-device-id", "::mlir::func::FuncOp"> {
let dependentDialects = [
"::mlir::func::FuncDialect",
Expand Down Expand Up @@ -1565,18 +1564,5 @@ def ApplyVectorLayoutPass : Pass<"tpu-apply-vector-layout", "::mlir::func::FuncO
];
}

def PreCanonicalizationOptimizationPass : Pass<"pre-canonicalization-optimization", "::mlir::func::FuncOp"> {
let summary = "Fold matmul rhs tranpose into the op before layout inference";
let constructor = "::mlir::tpu::createPreCanonicalizationOptimizationPass()";
let dependentDialects = [
"::mlir::vector::VectorDialect",
"::mlir::tpu::TPUDialect",
];
let options = [
Option<"hardware_generation", "hardware-generation", "int", /*default=*/"6", "">,
Option<"lane_count", "lane-count", "int", /*default=*/"128", "">,
Option<"sublane_count", "sublane-count", "int", /*default=*/"8", "">,
];
}

#endif // TPU_ATTRS
5 changes: 0 additions & 5 deletions jaxlib/mosaic/dialect/tpu/tpu_dialect.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,6 @@ std::unique_ptr<OperationPass<func::FuncOp>> createRelayoutInsertionPass(
std::unique_ptr<OperationPass<func::FuncOp>> createApplyVectorLayoutPass(
const ApplyVectorLayoutContext &ctx = ApplyVectorLayoutContext{});

std::unique_ptr<OperationPass<func::FuncOp>>
createPreCanonicalizationOptimizationPass(
int hardware_generation = -1,
std::array<int64_t, 2> target_shape = {8, 128});

std::unique_ptr<OperationPass<func::FuncOp>>
createLogicalToPhysicalDeviceIdPass(int64_t total_devices);

Expand Down
Loading