Skip to content

Conversation

@neolyte
Copy link
Contributor

@neolyte neolyte commented Nov 14, 2019

Update the default job types displayed on README.md as they are not representing what they really are anymore and can be confusing.

Update the default job types displayed on README.md as they are not representing what they really are anymore and can be confusing.
Base automatically changed from master to main January 20, 2021 18:17
Copy link

@brandonzylstra brandonzylstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to re-order 'runner' and 'script'? It makes the diff less clean.

(I don't have authority to accept your PR here on javan's repo, but I see the merits in your PR, and would like to see it merged. This documentation bug just bit me too.)

@neolyte
Copy link
Contributor Author

neolyte commented Mar 8, 2022

Is there any reason to re-order 'runner' and 'script'? It makes the diff less clean.

(I don't have authority to accept your PR here on javan's repo, but I see the merits in your PR, and would like to see it merged. This documentation bug just bit me too.)

I believe (it's been a long time) probably because I simply copied how they are defined in the setup.rb file here

job_type :command, ":task :output"
That's how they are ordered there

Copy link
Contributor

@bragamat bragamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benlangfeld let's get it rebased and merged! 😄

@taketo1113 taketo1113 merged commit 53329ba into javan:main Dec 4, 2025
@taketo1113
Copy link
Collaborator

Thank you for your contribution.

@taketo1113 taketo1113 mentioned this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants