Skip to content

Conversation

@jasonyuezhang
Copy link
Owner

When I moved the outline to above all other rects, I thought it was clever to unify with the root so that the outline was also used for the root selection. But the root outline is not drawn like the other rects. It's outside the padding and doesn't have the 1px adjustment which leads the overlay to be slightly inside the other rect instead of above it.

This goes back to just having the selected root be drawn by the root element.

Before:

Screenshot 2025-11-07 at 11 39 28 AM

After:

Screenshot 2025-11-07 at 11 44 01 AM

Copied from facebook#35071
Original PR: facebook#35071

@macroscopeapp
Copy link

macroscopeapp bot commented Nov 7, 2025

Render root selection in DevTools Suspense tab with a 4px container outline and 0.125rem radius via .SuspenseRectsRootOutline and remove ScaledRect overlay for root

Introduce a root-specific container outline and drop the ScaledRect overlay when the root is selected. Update .SuspenseRectsContainer to append styles.SuspenseRectsRootOutline on isRootSelected and remove styles.SuspenseRectOutlineRoot. Add the 4px outline and 0.125rem radius in SuspenseRects.css and adjust logic in SuspenseRects.js.

📍Where to Start

Start with the SuspenseRectsContainer component in SuspenseRects.js to review the root selection logic and class assignment, then verify styles in SuspenseRects.css.


Macroscope summarized 38fc9e6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants