#2562 thread warden #2563
Merged
#2562 thread warden #2563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in scene graph operations. This update adds the SceneGraphThreadWarden to enforce that scene graph mutations occur only on the main thread IF those nodes are already part of the main scene graph
…here all nodes were restricted
Introduce tests to verify thread safety of scene graph mutations under various conditions. Includes checks for both main-thread and non-main-thread scenarios with attached and detached objects. Ensures compliance with scene graph thread safety guarantees.
… handling Added tests to validate thread safety in scenarios involving nested nodes, such as attaching/detaching children and grandchildren. Ensures proper restriction and release of thread protections for hierarchical structures. This strengthens coverage for complex scene graph operations.
…ort for disabling the thread warden via a system property.
…ice is being used where futures aren't promptly collected)
riccardobl
requested changes
Sep 27, 2025
Member
riccardobl
left a comment
riccardobl
left a comment
There was a problem hiding this comment.
Thanks! This is going to be very useful.
I've commented some minor details I'd like you to review 👍
…all be optised out
riccardobl
approved these changes
Sep 27, 2025
Member
|
Thanks! I am going to merge this asap on my fork, to give it some testing, just in case we are overlooking on some side effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The scene graph (that is connected to the root node) shouldn't be mutated from any thread but the main thread.
Unconnected nodes etc can be mutated on non main threads
What have I changed
Spatial mutations are now watched (when asserts are turned on) and if an illegal mutation is made an exception is fired
closes #2562