Skip to content

headless audio working but not in video recording #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

headless audio working but not in video recording #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ const config: PlaywrightTestConfig = {
actionTimeout: 0,
baseURL,
trace: 'on-first-retry',
headless: false,
video: 'on',
launchOptions: {
ignoreDefaultArgs: ['--mute-audio', '--disable-audio-output'],
slowMo: 3000,
},
},
projects: [
{
Expand Down
Binary file added public/audio.mp3
View file
Open in desktop
Binary file not shown.
16 changes: 15 additions & 1 deletion src/app/views/demo/Demo.view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const DemoView: Component = () => {
const [muted, setMuted] = createSignal(false);
const [profile, setProfile] = createSignal<Profile>('personal');
const [searchParams] = useSearchParams();
let audioElem;

const increment = () => {
setCount((prev) => (prev += 1));
Expand All @@ -25,7 +26,14 @@ const DemoView: Component = () => {
};

const handleMuteInput = () => {
setMuted((old) => !old);
const existingState = muted();
const newState = !existingState;
if (newState) {
audioElem.play();
} else {
audioElem.pause();
}
setMuted(newState);
};

const handleProfileChange = (event: Event) => {
Expand Down Expand Up @@ -145,6 +153,12 @@ const DemoView: Component = () => {
</strong>
<span>(click to toggle)</span>
</label>
<audio
src="/audio.mp3"
ref={audioElem}
controls
loop
/>
</div>
<Show when={muted()}>
<p class={demoStyles.demoInteractionDesc}>
Expand Down